smbios: Move detection of smbios earlier.
ClosedPublic
Actions

Authored by imp on May 22 2023, 10:28 PM.

Details

Reviewers

manu
tsoome
emaste
kevans

Commits

rG2efbc8e2840f: stand/efi/smbios: Move detection of smbios earlier.

Summary

It would be nice to make decisions early in boot, about maybe consoles,
based on smbios variables. Set them just after we setup the archsw so we
can use them everywhere.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 51617
Build 48508: arc lint + arc unit

Event Timeline

imp created this revision.May 22 2023, 10:28 PM

Herald added a reviewer: manu. · View Herald TranscriptMay 22 2023, 10:28 PM

Herald added subscribers: dab, bcran. · View Herald Transcript

imp requested review of this revision.May 22 2023, 10:28 PM

Harbormaster completed remote builds in B51617: Diff 122256.May 22 2023, 10:28 PM

imp added a child revision: D40220: stand/efi/eficom: better handling of absent device.May 22 2023, 10:28 PM

imp added reviewers: tsoome, emaste, kevans.May 22 2023, 10:30 PM

hm, do we actually need this preprocessor #if statement?

This revision is now accepted and ready to land.May 23 2023, 7:35 AM

In D40219#915745, @tsoome wrote:

hm, do we actually need this preprocessor #if statement?

We did until my smbios changes recently. I have a separate commit for that not yet in review

gallatin added a subscriber: gallatin.May 23 2023, 1:41 PM

kevans accepted this revision.May 24 2023, 7:48 PM

Closed by commit rG2efbc8e2840f: stand/efi/smbios: Move detection of smbios earlier. (authored by imp). · Explain WhyMay 25 2023, 4:34 AM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG2efbc8e2840f: stand/efi/smbios: Move detection of smbios earlier..

Revision Contents
Changeset List

Path

Size

stand/

efi/

loader/

main.c

32 lines

Diff 122256

View Options

stand/efi/smbios: Move detection of smbios earlier.ClosedPublicActions