Differential D39565

tcp: rack pacing has some caveats that need to be obeyed when LRO is missing.
ClosedPublic
Actions

Authored by rrs on Apr 13 2023, 8:16 PM.

Details

Reviewers

tuexen

Group Reviewers

transport

Commits

rG9903bf34f01f: tcp: rack pacing has some caveats that need to be obeyed when LRO is missing

Summary

In further non-LRO testing I found a case where rack is supposed to be waking up but
it is not now. In this special case it sets the flag rc_ack_can_sendout_data. When that is
set we should not prohibit output.

Test Plan

With the patch before a GP measurement is taken we should have ack's drive out new data (which
is the special case where the flag is set).

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

rrs created this revision.Apr 13 2023, 8:16 PM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptApr 13 2023, 8:16 PM

Herald added subscribers: glebius, melifaro. · View Herald Transcript

rrs requested review of this revision.Apr 13 2023, 8:16 PM

tuexen accepted this revision.Apr 13 2023, 8:38 PM

This revision is now accepted and ready to land.Apr 13 2023, 8:38 PM

Closed by commit rG9903bf34f01f: tcp: rack pacing has some caveats that need to be obeyed when LRO is missing (authored by rrs). · Explain WhyApr 14 2023, 1:34 PM

This revision was automatically updated to reflect the committed changes.

rrs added a commit: rG9903bf34f01f: tcp: rack pacing has some caveats that need to be obeyed when LRO is missing.

Herald added a subscriber: imp. · View Herald TranscriptApr 14 2023, 1:34 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_stacks/

rack.c

1 line

Diff 120281

View Options

sys/netinet/tcp_stacks/rack.c

tcp: rack pacing has some caveats that need to be obeyed when LRO is missing.ClosedPublicActions