Page MenuHomeFreeBSD
Differential D38957

tftpd: Make the transfer functions return success / failure.
ClosedPublic
Actions

Authored by des on Mar 7 2023, 7:48 PM.
Tags
None
Referenced Files
F169014259: D38957.id118617.diff
Mon, Aug 31, 3:17 AM
F169005715: D38957.id118487.diff
Mon, Aug 31, 2:53 AM
F169004457: D38957.diff
Mon, Aug 31, 2:49 AM
F169002741: D38957.id.diff
Mon, Aug 31, 2:41 AM
Unknown Object (File)
Sat, Aug 22, 3:35 PM
Unknown Object (File)
Tue, Aug 18, 11:51 AM
Unknown Object (File)
Mon, Aug 17, 6:41 PM
Unknown Object (File)
Mon, Aug 17, 1:57 PM
View All Files
Subscribers
markj

Details

Reviewers
imp
jhb
markj
Group Reviewers
Klara
Commits
rG36242fc0e56c: tftpd: Make the transfer functions return success / failure.
Summary

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Mar 7 2023, 7:48 PM
des created this revision.
Harbormaster completed remote builds in B50205: Diff 118487.Mar 7 2023, 7:48 PM
des added a parent revision: D38956: tftpd: Ensure that tftp_log() preserves errno..Mar 7 2023, 7:48 PM
des added a child revision: D38958: tftp: Correctly propagate transfer errors..
markj added a subscriber: markj.Mar 8 2023, 3:22 PM

Is there a follow-up revision which changes callers to do something with these return values?

des added a comment.Mar 8 2023, 4:58 PM
In D38957#887338, @markj wrote:

Is there a follow-up revision which changes callers to do something with these return values?

yes, D38958 which is linked as a child

markj accepted this revision as: markj.Mar 8 2023, 5:02 PM
This revision is now accepted and ready to land.Mar 8 2023, 5:02 PM
Closed by commit rG36242fc0e56c: tftpd: Make the transfer functions return success / failure. (authored by des). · Explain WhyMar 10 2023, 1:29 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG36242fc0e56c: tftpd: Make the transfer functions return success / failure..

Revision Contents
Changeset List

PathSize
libexec/
tftpd/
4 lines
38 lines

Diff 118617

View Options

libexec/tftpd/tftp-transfer.h

Loading...
View Options

libexec/tftpd/tftp-transfer.c

Loading...