Page MenuHomeFreeBSD
Differential D38958

tftp: Correctly propagate transfer errors.
ClosedPublic
Actions

Authored by des on Mar 7 2023, 7:48 PM.
Tags
None
Referenced Files
F169629656: D38958.id.diff
Wed, Sep 2, 3:04 AM
F169625828: D38958.id118540.diff
Wed, Sep 2, 2:44 AM
F169607004: D38958.diff
Wed, Sep 2, 1:27 AM
F169531244: D38958.id118618.diff
Tue, Sep 1, 8:17 PM
Unknown Object (File)
Mon, Aug 31, 3:13 AM
Unknown Object (File)
Mon, Aug 31, 2:58 AM
Unknown Object (File)
Mon, Aug 31, 2:53 AM
Unknown Object (File)
Mon, Aug 31, 1:51 AM
View All Files
Subscribers
markj

Details

Reviewers
imp
jhb
markj
Group Reviewers
Klara
Commits
rG92570f67c791: tftp: Correctly propagate transfer errors.
Summary

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 50206
Build 47098: arc lint + arc unit

Event Timeline

des requested review of this revision.Mar 7 2023, 7:48 PM
des created this revision.
Harbormaster completed remote builds in B50206: Diff 118488.Mar 7 2023, 7:48 PM
des added a parent revision: D38957: tftpd: Make the transfer functions return success / failure..Mar 7 2023, 7:49 PM
des added a child revision: D38965: tftpd: Make the -d option behave as documented..Mar 7 2023, 11:10 PM
markj added a subscriber: markj.Mar 8 2023, 3:09 PM
markj added inline comments.
usr.bin/tftp/tftp.c
105

Or just add a return value to this function and use that to signal an error? Then txrx_error can be private to main.c.

des mentioned this in D38957: tftpd: Make the transfer functions return success / failure..Mar 8 2023, 4:58 PM
des retitled this revision from tftp: Set txrx_error if and only if an error occurred. to tftp: Correctly propagate transfer errors..Mar 8 2023, 6:10 PM
des updated this revision to Diff 118540.Mar 8 2023, 6:11 PM

Reduce use of global error flag.

Harbormaster completed remote builds in B50234: Diff 118540.Mar 8 2023, 6:12 PM
des marked an inline comment as done.Mar 8 2023, 6:15 PM
markj accepted this revision as: markj.Mar 8 2023, 6:27 PM
markj added inline comments.
usr.bin/tftp/main.c
504 ↗(On Diff #118540)
This revision is now accepted and ready to land.Mar 8 2023, 6:27 PM
Closed by commit rG92570f67c791: tftp: Correctly propagate transfer errors. (authored by des). · Explain WhyMar 10 2023, 1:29 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG92570f67c791: tftp: Correctly propagate transfer errors..

Revision Contents
Changeset List

PathSize
usr.bin/
tftp/
22 lines

Diff 118488

View Options

usr.bin/tftp/tftp.c

Loading...