tftpd: Make the transfer functions return success / failure.
ClosedPublic
Actions

Authored by des on Mar 7 2023, 7:48 PM.

Details

Reviewers

imp
jhb
markj

Group Reviewers

Klara

Commits

rG36242fc0e56c: tftpd: Make the transfer functions return success / failure.

Summary

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 50205
Build 47097: arc lint + arc unit

Event Timeline

des requested review of this revision.Mar 7 2023, 7:48 PM

des created this revision.

Harbormaster completed remote builds in B50205: Diff 118487.Mar 7 2023, 7:48 PM

des added a parent revision: D38956: tftpd: Ensure that tftp_log() preserves errno..Mar 7 2023, 7:48 PM

des added a child revision: D38958: tftp: Correctly propagate transfer errors..

Is there a follow-up revision which changes callers to do something with these return values?

In D38957#887338, @markj wrote:

Is there a follow-up revision which changes callers to do something with these return values?

yes, D38958 which is linked as a child

markj accepted this revision as: markj.Mar 8 2023, 5:02 PM

This revision is now accepted and ready to land.Mar 8 2023, 5:02 PM

Closed by commit rG36242fc0e56c: tftpd: Make the transfer functions return success / failure. (authored by des). · Explain WhyMar 10 2023, 1:29 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rG36242fc0e56c: tftpd: Make the transfer functions return success / failure..

Revision Contents
Changeset List

Path

Size

libexec/

tftpd/

tftp-transfer.h

4 lines

tftp-transfer.c

38 lines

Diff 118487

View Options

libexec/tftpd/tftp-transfer.h