linux(4): Rename struct l_ifreq members names to avoid conflicts with FreeBSD
ClosedPublic
Actions

Authored by dchagin on Feb 26 2023, 10:00 AM.

Details

Reviewers

jhibbits

Group Reviewers

Linux Emulation

Commits

rGa927409ce820: linux(4): Rename struct l_ifreq members names to avoid conflicts with FreeBSD

Summary

For now we are using mixed names to access struct ifreq members, some
of Linux (ifr_name, ifr_ifindex), others of FreeBSD. To avoid conflicts
switch to use FreeBSD names.

Reported by: jhibbits

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 50111
Build 47003: arc lint + arc unit

Event Timeline

dchagin created this revision.Feb 26 2023, 10:00 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 26 2023, 10:00 AM

dchagin requested review of this revision.Feb 26 2023, 10:00 AM

Harbormaster completed remote builds in B50029: Diff 117956.Feb 26 2023, 10:00 AM

dchagin edited the summary of this revision. (Show Details)Feb 26 2023, 11:18 AM

dchagin added reviewers: Linux Emulation, jhibbits.

dchagin added a project: Linux Emulation.

Thanks!

This revision is now accepted and ready to land.Feb 27 2023, 12:40 AM

melifaro added a subscriber: melifaro.Feb 27 2023, 11:26 AM

melifaro added inline comments.

sys/compat/linux/linux_socket.h
342	I'd explicitly add `Static_assert()` conditions on each of the fields in linux_something.c. People don't read notes but have to read compiler errors :-)