inpcb: use family specific sockaddr argument for bind functions
ClosedPublic
Actions

Authored by glebius on Feb 15 2023, 2:40 AM.

Details

Reviewers

markj
zlei
melifaro

Group Reviewers

network
transport

Commits

rG96871af01382: inpcb: use family specific sockaddr argument for bind functions

Summary

Do the cast from sockaddr to either IPv4 or IPv6 sockaddr in the
protocol's pr_bind method and from there on go down the call
stack with family specific argument.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 49793
Build 46684: arc lint + arc unit

Event Timeline

glebius created this revision.Feb 15 2023, 2:40 AM

Herald added a reviewer: transport. · View Herald TranscriptFeb 15 2023, 2:40 AM

Herald added subscribers: melifaro, ae, imp. · View Herald Transcript

glebius requested review of this revision.Feb 15 2023, 2:40 AM

Harbormaster completed remote builds in B49793: Diff 117275.Feb 15 2023, 2:40 AM

Looks good to me.

Finally, we're getting rid of nam. Nice!

markj accepted this revision.Feb 15 2023, 2:37 PM

markj added inline comments.

sys/netinet/in_pcb.c
904	BTW, we are not consistent about using `struct in_addr` vs. `struct in_addr *` vs. `in_addr_t` in inpcb interfaces. It would be nice to simplify that too.