inpcb: Deduplicate some assertions
ClosedPublic
Actions

Authored by markj on Feb 2 2023, 10:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 13, 4:36 PM

	Unknown Object (File)
	Wed, May 13, 4:35 PM

	Unknown Object (File)
	Wed, May 13, 10:32 AM

	Unknown Object (File)
	Sun, May 3, 8:46 PM

	Unknown Object (File)
	Sun, May 3, 6:53 PM

	Unknown Object (File)
	Apr 23 2026, 11:08 PM

	Unknown Object (File)
	Apr 23 2026, 9:44 PM

	Unknown Object (File)
	Apr 21 2026, 6:19 PM

View All Files

Subscribers

imp

melifaro

Details

Reviewers

glebius

Group Reviewers

network

Commits

rG675e2618ae2d: inpcb: Deduplicate some assertions

Summary

It makes more sense to check lookupflags in the function which actually
uses SMR. No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 49495
Build 46385: arc lint + arc unit

Event Timeline

markj created this revision.Feb 2 2023, 10:41 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptFeb 2 2023, 10:41 PM

markj requested review of this revision.Feb 2 2023, 10:41 PM

Harbormaster completed remote builds in B49495: Diff 116370.Feb 2 2023, 10:41 PM

markj added a child revision: D38360: jail: Use atomic(9) instead of CK atomics.Feb 2 2023, 10:41 PM

glebius accepted this revision.Feb 2 2023, 11:51 PM

This revision is now accepted and ready to land.Feb 2 2023, 11:51 PM

Closed by commit rG675e2618ae2d: inpcb: Deduplicate some assertions (authored by markj). · Explain WhyFeb 3 2023, 4:52 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG675e2618ae2d: inpcb: Deduplicate some assertions.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

in_pcb.c

17 lines

netinet6/

in6_pcb.c

17 lines

Diff 116370

View Options

sys/netinet/in_pcb.c