elf_common.h: define EF_ARM_EABI_VERSION
ClosedPublic
Actions

Authored by imp on Jan 20 2023, 9:58 PM.

Details

Reviewers

jrtc27
emaste
jhb
markj
kib
andrew
brooks

Commits

rG2c6b910716e9: elf_common.h: define EF_ARM_EABI_VERSION

Summary

The Linux distributions have had the EF_ARM_EABI_VERSION macro for a
while now. The kernel of arm* targets build depends on it being in the
host's elf.h environment. Add it here so it gets pulled in so there's
one fewer hack required to build a Linux kernel on a FreeBSD host.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 49186
Build 46075: arc lint + arc unit

Event Timeline

imp requested review of this revision.Jan 20 2023, 9:58 PM

imp created this revision.

Harbormaster completed remote builds in B49186: Diff 115374.Jan 20 2023, 9:58 PM

imp edited the test plan for this revision. (Show Details)Jan 20 2023, 10:00 PM

imp added reviewers: jrtc27, emaste, jhb, markj, kib, andrew, brooks.

FWIW, binutils' include/elf/arm.h defines this macro as well with the same semantics.

sys/sys/elf_common.h
335

This revision is now accepted and ready to land.Jan 20 2023, 10:00 PM

kib accepted this revision.Jan 20 2023, 10:04 PM

With jhb's fix

sys/sys/elf_common.h
328	Hm, Arm's spec calls this EF_ARM_ABIMASK, but both Linux and glibc call this EF_ARM_EABIMASK like us. Python's setuptools seems to be about the only thing that calls it by its "correct" name.