if_ovpn: include peer counters in a OVPN_NOTIF_DEL_PEER message
ClosedPublic
Actions

Authored by kp on Dec 5 2022, 4:31 PM.

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rGc357bf397f2e: if_ovpn: include peer counters in a OVPN_NOTIF_DEL_PEER message

Summary

When we remove a peer userspace can no longer retrieve its counters. To
ensure that userspace can get a full count of the entire session we now
include the counters in the deletion message.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 48616
Build 45502: arc lint + arc unit

Event Timeline

kp created this revision.Dec 5 2022, 4:31 PM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptDec 5 2022, 4:31 PM

kp requested review of this revision.Dec 5 2022, 4:31 PM

kp added a parent revision: D37605: if_ovpn: allow peer lookup by vpn4/vpn6 address.

kp added a child revision: D37607: if_ovpn: cleanup offsetof() use.

Harbormaster completed remote builds in B48616: Diff 113839.Dec 5 2022, 4:31 PM

zlei added a subscriber: zlei.Dec 6 2022, 8:14 AM

zlei added inline comments.

sys/net/if_ovpn.c
445	Maybe integrate D37607 firstly ?

kp added inline comments.Dec 6 2022, 9:41 AM

sys/net/if_ovpn.c
445	I did consider that, but it means introducing the OVPN_COUNTER and OVPN_PEER_COUNTER macros separately. Also rewriting history significantly, because I did the cleanup work last. There's good arguments for either order, I think, but I don't think it's very important either way.