Silence GCC warnings when using libc++ headers.
ClosedPublic
Actions

Authored by jhb on Nov 29 2022, 7:30 PM.

Details

Reviewers

emaste
imp

Commits

rG80a1e92e4f54: Silence GCC warnings when using libc++ headers.
rG442295c1fe84: Silence GCC warnings when using libc++ headers.

Summary

GCC 12 raises warnings about literal operator suffixes not preceded by
'_' in libc++ headers such as <string_view> as it doesn't recognize
libc++ headers being an implementation of the standard.

GCC 12 also warns about clang-specific pragmas in <locale>.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 48531
Build 45417: arc lint + arc unit

Event Timeline

jhb created this revision.Nov 29 2022, 7:30 PM

Herald added a subscriber: bdrewery. · View Herald TranscriptNov 29 2022, 7:30 PM

jhb requested review of this revision.Nov 29 2022, 7:30 PM

Harbormaster completed remote builds in B48531: Diff 113617.Nov 29 2022, 7:30 PM

imp added inline comments.Nov 29 2022, 7:52 PM

share/mk/bsd.sys.mk
216	Any reason we want to have this for all the files in the system?

jhb added a subscriber: dim.Nov 29 2022, 8:01 PM

jhb added inline comments.

share/mk/bsd.sys.mk
216	Because I couldn't find a way to shut it up for "any file that #includes <string_view>" or any host of other standard headers provided by libc++. In theory we could patch all the headers in libc++ to explicitly disable this warning via #pragma push/pop but that would probably give @dim nightmares. Similarly, we could perhaps patch <locale> but I suspect that wouldn't be ideal either.