Page MenuHomeFreeBSD
Differential D37524

if_ovpn: remove peer limit
ClosedPublic
Actions

Authored by kp on Nov 28 2022, 9:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 6, 8:15 AM
Unknown Object (File)
Fri, Apr 5, 8:58 PM
Unknown Object (File)
Mar 8 2024, 4:29 PM
Unknown Object (File)
Jan 30 2024, 6:10 AM
Unknown Object (File)
Dec 20 2023, 6:23 AM
Unknown Object (File)
Oct 26 2023, 8:39 AM
Unknown Object (File)
Oct 17 2023, 8:40 AM
Unknown Object (File)
Jul 28 2023, 12:56 PM
View All 23 Files
Subscribers
ae
glebius
imp
melifaro
zlei

Details

Reviewers
zlei
Group Reviewers
network
pfsense
Commits
rG97c802923e20: if_ovpn: remove peer limit
Summary

Replace the fixed-sized array by an RB_TREE. This should both speed up
lookups and remove the 128 peer limit.

We may wish to consider adding additional trees to also speed up the
lookup by IPv4/IPv6 addresses.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 48525
Build 45411: arc lint + arc unit

Event Timeline

kp created this revision.Nov 28 2022, 9:21 PM
Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptNov 28 2022, 9:21 PM
kp requested review of this revision.Nov 28 2022, 9:21 PM
Harbormaster completed remote builds in B48525: Diff 113579.Nov 28 2022, 9:21 PM
zlei added a subscriber: zlei.Nov 29 2022, 12:56 AM
zlei added inline comments.Nov 29 2022, 3:54 AM
sys/net/if_ovpn.c
284

(struct ovpn_kpeer *)&p

The cast looks redundant. p is declared as struct ovpn_kpeer at line 278

1639

IPv6

kp updated this revision to Diff 113595.Nov 29 2022, 9:31 AM
  • review remarks
Harbormaster completed remote builds in B48530: Diff 113595.Nov 29 2022, 9:31 AM
kp marked 2 inline comments as done.Nov 29 2022, 9:32 AM

Good catch.

zlei accepted this revision.Dec 1 2022, 10:10 AM

Looks good to me.

And you may also want to retire OVPN_MAX_PEERS ;)

This revision is now accepted and ready to land.Dec 1 2022, 10:10 AM
kp added a comment.Dec 1 2022, 10:24 AM
In D37524#854386, @zlei wrote:

Looks good to me.

And you may also want to retire OVPN_MAX_PEERS ;)

Thanks. I spotted that one eventually and fixed it, but figured it wasn't worth updating the review for that.

Closed by commit rG97c802923e20: if_ovpn: remove peer limit (authored by kp). · Explain WhyDec 1 2022, 4:43 PM
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG97c802923e20: if_ovpn: remove peer limit.

Revision Contents
Changeset List

PathSize
sys/
net/
142 lines

Diff 113579

View Options

sys/net/if_ovpn.c

Loading...