if_ovpn: remove peer limit
ClosedPublic
Actions

Authored by kp on Nov 28 2022, 9:21 PM.

Details

Reviewers

Group Reviewers

network
pfsense

Commits

rG97c802923e20: if_ovpn: remove peer limit

Summary

Replace the fixed-sized array by an RB_TREE. This should both speed up
lookups and remove the 128 peer limit.

We may wish to consider adding additional trees to also speed up the
lookup by IPv4/IPv6 addresses.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Nov 28 2022, 9:21 PM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptNov 28 2022, 9:21 PM

kp requested review of this revision.Nov 28 2022, 9:21 PM

Harbormaster completed remote builds in B48525: Diff 113579.Nov 28 2022, 9:21 PM

zlei added a subscriber: zlei.Nov 29 2022, 12:56 AM

zlei added inline comments.Nov 29 2022, 3:54 AM

sys/net/if_ovpn.c
269	`(struct ovpn_kpeer *)&p` The cast looks redundant. `p` is declared as `struct ovpn_kpeer` at line 278
1620–1623	IPv6

review remarks

Harbormaster completed remote builds in B48530: Diff 113595.Nov 29 2022, 9:31 AM

Good catch.

Looks good to me.

And you may also want to retire OVPN_MAX_PEERS ;)

This revision is now accepted and ready to land.Dec 1 2022, 10:10 AM

In D37524#854386, @zlei wrote:

Looks good to me.

And you may also want to retire OVPN_MAX_PEERS ;)

Thanks. I spotted that one eventually and fixed it, but figured it wasn't worth updating the review for that.

Closed by commit rG97c802923e20: if_ovpn: remove peer limit (authored by kp). · Explain WhyDec 1 2022, 4:43 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG97c802923e20: if_ovpn: remove peer limit.

Revision Contents
Changeset List

Path

Size

sys/

net/

if_ovpn.c

136 lines

Diff 113758

View Options

if_ovpn: remove peer limitClosedPublicActions