stdlib.h: Fix qsort_r compatibility with GCC 12.
ClosedPublic
Actions

Authored by jhb on Nov 16 2022, 5:41 PM.

Details

Reviewers

ed
emaste

Commits

rG43703bc489ec: stdlib.h: Fix qsort_r compatibility with GCC 12.

Summary

GCC 12 (unlike GCC 9) does not match a function argument passed to the
old qsort_r() API (as is used in the qsort_r_compat test) to a
function pointer type via __generic. It treats the function type as a
distinct type from a function pointer. As a workaround, add a second
definition of qsort_r for GCC 12 which uses the bare function type.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 48394
Build 45280: arc lint + arc unit

Event Timeline

jhb created this revision.Nov 16 2022, 5:41 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 16 2022, 5:41 PM

jhb requested review of this revision.Nov 16 2022, 5:41 PM

Harbormaster completed remote builds in B48394: Diff 113211.Nov 16 2022, 5:41 PM

Ping?

This breaks the build with clang as clang says a _Generic selector can only have an object type and a function pointer type isn't valid. GCC 9 was happy with the existing version, so this might be some regression in GCC 10, 11, or 12.

jhb updated this revision to Diff 115322.Jan 19 2023, 6:22 PM

Harbormaster completed remote builds in B49169: Diff 115322.Jan 19 2023, 6:22 PM

This is a bit of a stop-gap. I probably should create a smaller reproducible test case to submit as a bug upstream to GCC.