Differential D38216

Revert "stdlib.h: Fix qsort_r compatibility with GCC 12."
ClosedPublic
Actions

Authored by jhb on Jan 26 2023, 9:56 PM.

Tags

None

Referenced Files

	F131667493: D38216.id115844.diff
	Fri, Oct 10, 4:36 AM

	F131667492: D38216.id115905.diff
	Fri, Oct 10, 4:36 AM

	F131667490: D38216.id.diff
	Fri, Oct 10, 4:36 AM

	F131639550: D38216.diff
	Thu, Oct 9, 11:17 PM

	Unknown Object (File)
	Thu, Oct 9, 1:31 AM

	Unknown Object (File)
	Thu, Oct 2, 4:11 AM

	Unknown Object (File)
	Thu, Sep 18, 4:52 PM

	Unknown Object (File)
	Sep 5 2025, 3:54 AM

Subscribers

Details

Reviewers

Commits

rGe5dc40935f6e: Revert "stdlib.h: Fix qsort_r compatibility with GCC 12."

Summary

This reverts commit 43703bc489ec504b947b869045c492ed38c1a69c.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jan 26 2023, 9:56 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 26 2023, 9:56 PM

jhb requested review of this revision.Jan 26 2023, 9:56 PM

jhb added a parent revision: D38215: <sys/cdefs.h>: Decay expression passed to fallback version of __generic().

Harbormaster completed remote builds in B49253: Diff 115844.Jan 26 2023, 9:56 PM

I think these can come in either order and break each other regardless? If so might be tempted to revert first.

In D38216#868503, @jrtc27 wrote:

I think these can come in either order and break each other regardless? If so might be tempted to revert first.

Oh right, I guess it does break both ways. I had reverted first locally actually to make sure I could reproduce the breakage before testing the cdefs.h change. I can commit them in that order (revert first).

jrtc27 accepted this revision.Jan 27 2023, 12:20 AM

This revision is now accepted and ready to land.Jan 27 2023, 12:20 AM

Closed by commit rGe5dc40935f6e: Revert "stdlib.h: Fix qsort_r compatibility with GCC 12." (authored by jhb). · Explain WhyJan 27 2023, 12:29 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGe5dc40935f6e: Revert "stdlib.h: Fix qsort_r compatibility with GCC 12.".

Revision Contents
Changeset List

Path

Size

include/

6 lines

Diff 115905

include/stdlib.h

Loading...