Differential D38216

Revert "stdlib.h: Fix qsort_r compatibility with GCC 12."
ClosedPublic
Actions

Authored by jhb on Jan 26 2023, 9:56 PM.

Tags

None

Referenced Files

	F108182924: D38216.diff
	Wed, Jan 22, 8:36 AM

	Unknown Object (File)
	Mon, Jan 20, 12:04 PM

	Unknown Object (File)
	Thu, Jan 16, 6:06 PM

	Unknown Object (File)
	Tue, Jan 14, 5:33 AM

	Unknown Object (File)
	Tue, Jan 14, 5:33 AM

	Unknown Object (File)
	Tue, Jan 14, 5:32 AM

	Unknown Object (File)
	Tue, Jan 14, 1:38 AM

	Unknown Object (File)
	Mon, Jan 13, 8:08 PM

View All 73 Files

Subscribers

Details

Reviewers

Commits

rGe5dc40935f6e: Revert "stdlib.h: Fix qsort_r compatibility with GCC 12."

Summary

This reverts commit 43703bc489ec504b947b869045c492ed38c1a69c.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 49253
Build 46143: arc lint + arc unit

Event Timeline

jhb created this revision.Jan 26 2023, 9:56 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 26 2023, 9:56 PM

jhb requested review of this revision.Jan 26 2023, 9:56 PM

jhb added a parent revision: D38215: <sys/cdefs.h>: Decay expression passed to fallback version of __generic().

Harbormaster completed remote builds in B49253: Diff 115844.Jan 26 2023, 9:56 PM

I think these can come in either order and break each other regardless? If so might be tempted to revert first.

In D38216#868503, @jrtc27 wrote:

I think these can come in either order and break each other regardless? If so might be tempted to revert first.

Oh right, I guess it does break both ways. I had reverted first locally actually to make sure I could reproduce the breakage before testing the cdefs.h change. I can commit them in that order (revert first).

jrtc27 accepted this revision.Jan 27 2023, 12:20 AM

This revision is now accepted and ready to land.Jan 27 2023, 12:20 AM

Closed by commit rGe5dc40935f6e: Revert "stdlib.h: Fix qsort_r compatibility with GCC 12." (authored by jhb). · Explain WhyJan 27 2023, 12:29 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGe5dc40935f6e: Revert "stdlib.h: Fix qsort_r compatibility with GCC 12.".

Revision Contents
Changeset List

Path

Size

include/

6 lines

Diff 115844

include/stdlib.h

Loading...