Page MenuHomeFreeBSD

stdlib.h: Fix qsort_r compatibility with GCC 12.

Authored by jhb on Nov 16 2022, 5:41 PM.
Referenced Files
Unknown Object (File)
Fri, Feb 3, 9:59 AM
Unknown Object (File)
Sat, Jan 28, 5:03 PM
Unknown Object (File)
Thu, Jan 19, 10:49 PM
Unknown Object (File)
Tue, Jan 17, 10:32 AM
Unknown Object (File)
Dec 16 2022, 1:23 PM
Unknown Object (File)
Nov 27 2022, 10:41 AM



GCC 12 (unlike GCC 9) does not match a function argument passed to the
old qsort_r() API (as is used in the qsort_r_compat test) to a
function pointer type via __generic. It treats the function type as a
distinct type from a function pointer. As a workaround, add a second
definition of qsort_r for GCC 12 which uses the bare function type.

Diff Detail

rG FreeBSD src repository
Lint Not Applicable
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Nov 16 2022, 5:41 PM

This breaks the build with clang as clang says a _Generic selector can only have an object type and a function pointer type isn't valid. GCC 9 was happy with the existing version, so this might be some regression in GCC 10, 11, or 12.

This is a bit of a stop-gap. I probably should create a smaller reproducible test case to submit as a bug upstream to GCC.


I haven't tested GCC 10 or 11.

LGTM as it applies only to GCC 12.
Would be great to have a small reproducer shared with upstream.

This revision is now accepted and ready to land.Thu, Jan 19, 7:10 PM