Page MenuHomeFreeBSD
Differential D37355

bhyve: nvme controller obey async event setting when reporting critical temperature
ClosedPublic
Actions

Authored by wanpengqian_gmail.com on Nov 11 2022, 7:59 AM.
Tags
None
Referenced Files
F137144743: D37355.id.diff
Fri, Nov 21, 6:34 AM
Unknown Object (File)
Tue, Nov 18, 11:00 AM
Unknown Object (File)
Thu, Nov 13, 12:37 AM
Unknown Object (File)
Mon, Nov 10, 12:59 PM
Unknown Object (File)
Sun, Nov 9, 3:33 AM
Unknown Object (File)
Sat, Nov 8, 5:48 PM
Unknown Object (File)
Sat, Nov 8, 1:24 PM
Unknown Object (File)
Wed, Oct 29, 8:54 AM
View All Files
Subscribers
bcran
corvink
dab
imp
manu
rgrimes

Details

Reviewers
corvink
Group Reviewers
bhyve
Commits
rGc18ebe522814: bhyve: nvme controller obey async event setting when reporting critical…
rG10846c53c456: bhyve: nvme controller obey async event setting when reporting critical…
Summary

async event report is controlled by async event configuration feature setting.
when reporting a critical temperature warning, check the async event configuration.

Test Plan

trigger a critical temperature event whether the on/off setting is effective.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 48306
Build 45192: arc lint + arc unit

Event Timeline

wanpengqian_gmail.com created this revision.Nov 11 2022, 7:59 AM
Herald added a reviewer: bhyve. · View Herald TranscriptNov 11 2022, 7:59 AM
Herald added subscribers: dab, bcran, rgrimes, imp. · View Herald Transcript
wanpengqian_gmail.com requested review of this revision.Nov 11 2022, 7:59 AM
Harbormaster completed remote builds in B48287: Diff 112911.Nov 11 2022, 7:59 AM
corvink added a subscriber: corvink.Nov 11 2022, 11:26 AM
corvink added inline comments.
usr.sbin/bhyve/pci_nvme.c
1761
wanpengqian_gmail.com updated this revision to Diff 112940.Nov 11 2022, 3:28 PM

drop init value of report_crit

Harbormaster completed remote builds in B48306: Diff 112940.Nov 11 2022, 3:28 PM
wanpengqian_gmail.com marked an inline comment as done.Nov 11 2022, 3:31 PM

address feedback

usr.sbin/bhyve/pci_nvme.c
1761

this init value will be overridden by the following statement. I think giving an init value to false is reasonable at first.

corvink accepted this revision.Nov 14 2022, 10:48 AM
corvink added a subscriber: manu.

LGTM @manu

This revision is now accepted and ready to land.Nov 14 2022, 10:48 AM
manu added a comment.Nov 14 2022, 10:59 AM
In D37355#849624, @corvink wrote:

LGTM @manu

Approved.

Closed by commit rG10846c53c456: bhyve: nvme controller obey async event setting when reporting critical… (authored by wanpengqian_gmail.com, committed by corvink). · Explain WhyNov 15 2022, 7:26 AM
This revision was automatically updated to reflect the committed changes.
corvink added a commit: rG10846c53c456: bhyve: nvme controller obey async event setting when reporting critical….
corvink added a commit: rGc18ebe522814: bhyve: nvme controller obey async event setting when reporting critical….Nov 23 2022, 9:45 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
7 lines

Diff 112940

View Options

usr.sbin/bhyve/pci_nvme.c

Loading...