Page MenuHomeFreeBSD
Differential D36938

Downgrade tty_intr_event from a global
ClosedPublic
Actions

Authored by mhorne on Oct 11 2022, 5:17 PM.
Tags
None
Referenced Files
F169275055: D36938.id111650.diff
Tue, Sep 1, 2:56 AM
F169156932: D36938.diff
Mon, Aug 31, 3:11 PM
F169105690: D36938.id111715.diff
Mon, Aug 31, 10:34 AM
F169047913: D36938.id.diff
Mon, Aug 31, 6:02 AM
Unknown Object (File)
Sat, Aug 29, 11:26 PM
Unknown Object (File)
Sat, Aug 29, 10:48 AM
Unknown Object (File)
Sat, Aug 29, 5:57 AM
Unknown Object (File)
Thu, Aug 27, 6:45 AM
View All Files
Subscribers
None

Details

Reviewers
imp
jhb
markj
Commits
rGb34de75d61c2: Downgrade tty_intr_event from a global
rG05b727fee550: Downgrade tty_intr_event from a global
Summary

It can be static within uart_tty.c.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47779
Build 44666: arc lint + arc unit

Event Timeline

mhorne requested review of this revision.Oct 11 2022, 5:17 PM
mhorne created this revision.
Harbormaster completed remote builds in B47779: Diff 111650.Oct 11 2022, 5:17 PM
mhorne added a parent revision: D36937: swi(9): clean up description of clk_intr_event.Oct 11 2022, 5:17 PM
mhorne added a child revision: D36939: swi(9): remove BUGS section.
markj accepted this revision.Oct 11 2022, 5:29 PM
This revision is now accepted and ready to land.Oct 11 2022, 5:29 PM
jhb accepted this revision.Oct 11 2022, 5:55 PM
jhb added inline comments.
sys/dev/uart/uart_tty.c
80

Is this even a useful thing to do now vs just having per-instance threads? In pre-SMPng we had limited bits for SWIs.

imp accepted this revision.Oct 11 2022, 6:55 PM
imp added inline comments.
sys/dev/uart/uart_tty.c
80

This change is fine, but would be redundant if we did that :)

mhorne added inline comments.Oct 11 2022, 7:03 PM
sys/dev/uart/uart_tty.c
80

I'll make a note of this notion in the commit message, but in my own self-interest I will avoid making that behaviour change :)

Closed by commit rG05b727fee550: Downgrade tty_intr_event from a global (authored by mhorne). · Explain WhyOct 12 2022, 4:46 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG05b727fee550: Downgrade tty_intr_event from a global.
mhorne added a commit: rGb34de75d61c2: Downgrade tty_intr_event from a global.Oct 19 2022, 1:51 PM

Revision Contents
Changeset List

PathSize
share/
man/
man9/
13 lines
sys/
dev/
uart/
3 lines
kern/
1 line
sys/
1 line

Diff 111650

View Options

share/man/man9/swi.9

Loading...
View Options

sys/dev/uart/uart_tty.c

Loading...
View Options

sys/kern/kern_intr.c

Loading...
View Options

sys/sys/interrupt.h

Loading...