Page MenuHomeFreeBSD
Differential D36042

vt 3 clicks paste
ClosedPublic
Actions

Authored by tezeka_hotmail.com on Aug 4 2022, 1:58 PM.
Tags
None
Referenced Files
F169416614: D36042.id108882.diff
Tue, Sep 1, 12:02 PM
F169415202: D36042.id108879.diff
Tue, Sep 1, 11:57 AM
F169315017: D36042.id108879.diff
Tue, Sep 1, 4:37 AM
Unknown Object (File)
Mon, Aug 31, 9:45 AM
Unknown Object (File)
Mon, Aug 31, 4:49 AM
Unknown Object (File)
Mon, Aug 31, 1:15 AM
Unknown Object (File)
Sun, Aug 30, 11:22 PM
Unknown Object (File)
Sun, Aug 30, 7:39 AM
View All Files
Subscribers
eduardo
imp

Details

Reviewers
• hselasky
Commits
rG90536729a46c: vt(4): Clear paste buffer after pasting.
rG7edcf5ac8afb: vt(4): When cutting a line, append a newline character.
rGd2d30464365e: vt(4): Clear paste buffer after pasting.
rG90b89100548f: vt(4): When cutting a line, append a newline character.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tezeka_hotmail.com requested review of this revision.Aug 4 2022, 1:58 PM
tezeka_hotmail.com created this revision.
tezeka_hotmail.com updated this revision to Diff 108881.Aug 4 2022, 2:24 PM

we have two changes in this patch.

first one is regarding the 3 clicks paste.
vtbuf_extract_marked() gains a new arg
int mark

the second change is not much of a change because i had to mess up the
case VT_MOUSE_EXTENDBUTTON:

this change is regarding the highlight mark that doesnt disappear from the screen after you paste it. the highlight mark stays forever
below solves the problem

ive replaced
mark = VTB_MARK_EXTEND;
with
mark = VTB_MARK_START

• hselasky added a reviewer: • hselasky.Aug 4 2022, 2:27 PM

Please remove all comments, //'s you've added containing old code.

tezeka_hotmail.com updated this revision to Diff 108882.Aug 4 2022, 2:49 PM

revoved the //'s old code comented as Hans requested

eduardo added a subscriber: eduardo.Aug 4 2022, 8:07 PM
• hselasky accepted this revision.Oct 5 2022, 8:56 AM

Looks good. I'll get this upstream and tested, possibly with some minor modifications.

This revision is now accepted and ready to land.Oct 5 2022, 8:56 AM
Closed by commit rG90b89100548f: vt(4): When cutting a line, append a newline character. (authored by tezeka_hotmail.com, committed by • hselasky). · Explain WhyOct 5 2022, 9:55 AM
This revision was automatically updated to reflect the committed changes.
• hselasky added a commit: rG90b89100548f: vt(4): When cutting a line, append a newline character..
Herald added a subscriber: imp. · View Herald TranscriptOct 5 2022, 9:55 AM
• hselasky added a commit: rGd2d30464365e: vt(4): Clear paste buffer after pasting..Oct 5 2022, 9:55 AM
• hselasky added a commit: rG7edcf5ac8afb: vt(4): When cutting a line, append a newline character..Oct 12 2022, 3:56 PM
• hselasky added a commit: rG90536729a46c: vt(4): Clear paste buffer after pasting..

Revision Contents
Changeset List

PathSize
sys/
dev/
vt/
2 lines
6 lines
5 lines

Diff 111451

View Options

sys/dev/vt/vt.h

Loading...
View Options

sys/dev/vt/vt_buf.c

Loading...
View Options

sys/dev/vt/vt_core.c

Loading...