Page MenuHomeFreeBSD
Differential D36794

if_vxlan(4): Check the size of data available in mbuf before using them
ClosedPublic
Actions

Authored by zlei on Sep 29 2022, 2:08 PM.
Tags
Referenced Files
F86156783: D36794.id.diff
Sun, Jun 16, 7:16 AM
Unknown Object (File)
Thu, Jun 6, 4:47 PM
Unknown Object (File)
Mon, May 27, 2:21 PM
Unknown Object (File)
May 11 2024, 10:59 PM
Unknown Object (File)
Feb 9 2024, 3:51 AM
Unknown Object (File)
Dec 23 2023, 1:25 AM
Unknown Object (File)
Dec 12 2023, 12:12 PM
Unknown Object (File)
Oct 9 2023, 4:24 PM
View All 19 Files
Subscribers
ae
franco_opnsense.org
glebius
imp
kp
melifaro

Details

Reviewers
kp
Group Reviewers
network
Commits
rGa9c3d5de9ac8: if_vxlan(4): Check the size of data available in mbuf before using them
rG639aebb2aa0b: if_vxlan(4): Check the size of data available in mbuf before using them
rG0156c3f1f760: if_vxlan(4): Check the size of data available in mbuf before using them
rG8707cb19e681: if_vxlan(4): Check the size of data available in mbuf before using them
Summary

PR: 261711

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei created this revision.Sep 29 2022, 2:08 PM
Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptSep 29 2022, 2:08 PM
zlei requested review of this revision.Sep 29 2022, 2:08 PM
zlei added inline comments.Sep 29 2022, 2:11 PM
sys/net/if_vxlan.c
2852

Check it lazily may be better, i.e. after checking if running status.

franco_opnsense.org added a subscriber: franco_opnsense.org.Sep 29 2022, 2:21 PM
kp added a subscriber: kp.Sep 30 2022, 9:11 AM

This looks sane to me. We really do have to make sure there's enough contiguous data before we access it.

sys/net/if_vxlan.c
2852

I'm not sure it's worth having this check. m_pullup() simply won't do anything if the mbuf already has sufficient contiguous space.

zlei added inline comments.Sep 30 2022, 9:20 AM
sys/net/if_vxlan.c
2852

VXLAN over wireguard or some other setups that have deeper tunnels should be rare.
The m_pullup() is not defined as a macro or an inline function, thus a pre-check should be valuable.

kp accepted this revision as: kp.Sep 30 2022, 9:54 AM
This revision is now accepted and ready to land.Sep 30 2022, 9:54 AM
Closed by commit rG8707cb19e681: if_vxlan(4): Check the size of data available in mbuf before using them (authored by zlei, committed by kp). · Explain WhySep 30 2022, 11:59 AM
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG8707cb19e681: if_vxlan(4): Check the size of data available in mbuf before using them.
zlei added a commit: rG0156c3f1f760: if_vxlan(4): Check the size of data available in mbuf before using them.Nov 4 2022, 10:49 AM
zlei added a commit: rG639aebb2aa0b: if_vxlan(4): Check the size of data available in mbuf before using them.Nov 4 2022, 11:00 AM
kp added a commit: rGa9c3d5de9ac8: if_vxlan(4): Check the size of data available in mbuf before using them.Nov 4 2022, 12:22 PM

Revision Contents
Changeset List

PathSize
sys/
net/
6 lines

Diff 111268

View Options

sys/net/if_vxlan.c

Loading...