Page MenuHomeFreeBSD
Differential D36837

pf: use time_to for timestamps
ClosedPublic
Actions

Authored by kp on Sep 30 2022, 7:43 AM.
Tags
None
Referenced Files
F111087064: D36837.id111262.diff
Thu, Feb 27, 6:04 AM
Unknown Object (File)
Tue, Feb 25, 12:59 AM
Unknown Object (File)
Sat, Feb 22, 8:21 PM
Unknown Object (File)
Tue, Feb 18, 4:41 AM
Unknown Object (File)
Jan 6 2025, 7:53 AM
Unknown Object (File)
Dec 9 2024, 12:30 PM
Unknown Object (File)
Dec 4 2024, 3:50 AM
Unknown Object (File)
Nov 25 2024, 9:22 AM
View All 58 Files
Subscribers
ae
farrokhi
glebius
imp
melifaro
zlei

Details

Reviewers
None
Group Reviewers
network
pfsense
Commits
rG1d090028d303: pf: use time_to for timestamps
Summary

Use time_t rather than uint32_t to represent the timestamps. That means
we have 64 bits rather than 32 on all platforms except i386, avoiding
the Y2K38 issues on most platforms.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47653
Build 44540: arc lint + arc unit

Event Timeline

kp created this revision.Sep 30 2022, 7:43 AM
Herald added subscribers: glebius, melifaro, farrokhi and 2 others. · View Herald TranscriptSep 30 2022, 7:43 AM
kp requested review of this revision.Sep 30 2022, 7:43 AM
Harbormaster completed remote builds in B47653: Diff 111262.Sep 30 2022, 7:43 AM
zlei added a subscriber: zlei.Sep 30 2022, 4:26 PM

Looks good to me.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 5 2022, 4:15 PM
Closed by commit rG1d090028d303: pf: use time_to for timestamps (authored by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.
kp added a commit: rG1d090028d303: pf: use time_to for timestamps.

Revision Contents
Changeset List

PathSize
lib/
libpfctl/
4 lines
sbin/
pfctl/
8 lines
sys/
net/
6 lines
netpfil/
pf/
14 lines

Diff 111262

View Options

lib/libpfctl/libpfctl.h

Loading...
View Options

sbin/pfctl/pfctl.c

Loading...
View Options

sys/net/pfvar.h

Loading...
View Options

sys/netpfil/pf/pf_ioctl.c

Loading...