Differential D36801

Micro-optimize the application of MADV_WILLNEED to existing superpage mappings
ClosedPublic
Actions

Authored by alc on Sep 29 2022, 6:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 22, 12:21 AM

	Unknown Object (File)
	Tue, May 21, 11:14 PM

	Unknown Object (File)
	Fri, May 10, 9:09 AM

	Unknown Object (File)
	Sat, May 4, 11:15 PM

	Unknown Object (File)
	Apr 26 2024, 6:13 PM

	Unknown Object (File)
	Apr 25 2024, 10:31 AM

	Unknown Object (File)
	Apr 24 2024, 11:50 PM

	Unknown Object (File)
	Apr 24 2024, 11:46 PM

View All 53 Files

Subscribers

Details

Reviewers

kib
markj
manu

Commits

rG1d5ebad06c20: pmap: optimize MADV_WILLNEED on existing superpages

Summary

Specifically, avoid the pointless calls to pmap_enter_quick_locked().

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

alc created this revision.Sep 29 2022, 6:16 PM

Herald added a reviewer: manu. · View Herald TranscriptSep 29 2022, 6:16 PM

Herald added subscribers: emaste, andrew. · View Herald Transcript

alc requested review of this revision.Sep 29 2022, 6:16 PM

kib accepted this revision.Sep 29 2022, 8:07 PM

This revision is now accepted and ready to land.Sep 29 2022, 8:07 PM

markj accepted this revision.Sep 30 2022, 2:33 PM

alc mentioned this in D36563: riscv: handle existing mapping in pmap_enter_l2().Sep 30 2022, 4:54 PM

Closed by commit rG1d5ebad06c20: pmap: optimize MADV_WILLNEED on existing superpages (authored by alc). · Explain WhySep 30 2022, 5:15 PM

This revision was automatically updated to reflect the committed changes.

alc added a commit: rG1d5ebad06c20: pmap: optimize MADV_WILLNEED on existing superpages.

Herald added a subscriber: imp. · View Herald TranscriptSep 30 2022, 5:15 PM

mhorne added a subscriber: mhorne.Oct 4 2022, 3:45 PM

mhorne added inline comments.

sys/amd64/amd64/pmap.c
7321	I believe this is meant to say KERN_RESOURCE_SHORTAGE instead. I can make the adjustment when I commit the related riscv pmap changes, if you like.

alc added inline comments.Oct 4 2022, 5:32 PM

sys/amd64/amd64/pmap.c
7321	Yes, you are correct. Yes, please make the fix when you commit the riscv changes.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

amd64/

64 lines

arm64/

arm64/

59 lines

Diff 111205

sys/amd64/amd64/pmap.c

Loading...

sys/arm64/arm64/pmap.c

Loading...