Paths

Table of Contentst

Differential D36794

if_vxlan(4): Check the size of data available in mbuf before using them
ClosedPublic
Actions

Authored by zlei on Sep 29 2022, 2:08 PM.

Tags

Referenced Files

	F86765175: D36794.id111268.diff
	Tue, Jun 25, 5:44 AM

	Unknown Object (File)
	Sun, Jun 23, 5:24 AM

	Unknown Object (File)
	Sun, Jun 16, 9:36 AM

	Unknown Object (File)
	Sun, Jun 16, 7:16 AM

	Unknown Object (File)
	Thu, Jun 6, 4:47 PM

	Unknown Object (File)
	Mon, May 27, 2:21 PM

	Unknown Object (File)
	May 11 2024, 10:59 PM

	Unknown Object (File)
	Feb 9 2024, 3:51 AM

View All 22 Files

Subscribers

franco_opnsense.org

Details

Reviewers

Group Reviewers

Commits

rGa9c3d5de9ac8: if_vxlan(4): Check the size of data available in mbuf before using them
rG639aebb2aa0b: if_vxlan(4): Check the size of data available in mbuf before using them
rG0156c3f1f760: if_vxlan(4): Check the size of data available in mbuf before using them
rG8707cb19e681: if_vxlan(4): Check the size of data available in mbuf before using them

Summary

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

zlei created this revision.Sep 29 2022, 2:08 PM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptSep 29 2022, 2:08 PM

zlei requested review of this revision.Sep 29 2022, 2:08 PM

zlei added inline comments.Sep 29 2022, 2:11 PM

sys/net/if_vxlan.c
2852	Check it lazily may be better, i.e. after checking if running status.

franco_opnsense.org added a subscriber: franco_opnsense.org.Sep 29 2022, 2:21 PM

This looks sane to me. We really do have to make sure there's enough contiguous data before we access it.

sys/net/if_vxlan.c
2852	I'm not sure it's worth having this check. m_pullup() simply won't do anything if the mbuf already has sufficient contiguous space.

zlei added inline comments.Sep 30 2022, 9:20 AM

sys/net/if_vxlan.c
2852	VXLAN over wireguard or some other setups that have deeper tunnels should be rare. The `m_pullup()` is not defined as a macro or an inline function, thus a pre-check should be valuable.

kp accepted this revision as: kp.Sep 30 2022, 9:54 AM

This revision is now accepted and ready to land.Sep 30 2022, 9:54 AM

Closed by commit rG8707cb19e681: if_vxlan(4): Check the size of data available in mbuf before using them (authored by zlei, committed by kp). · Explain WhySep 30 2022, 11:59 AM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG8707cb19e681: if_vxlan(4): Check the size of data available in mbuf before using them.

zlei added a commit: rG0156c3f1f760: if_vxlan(4): Check the size of data available in mbuf before using them.Nov 4 2022, 10:49 AM

zlei added a commit: rG639aebb2aa0b: if_vxlan(4): Check the size of data available in mbuf before using them.Nov 4 2022, 11:00 AM

kp added a commit: rGa9c3d5de9ac8: if_vxlan(4): Check the size of data available in mbuf before using them.Nov 4 2022, 12:22 PM

Revision Contents
Changeset List

Path

Size

sys/

net/

6 lines

Diff 111184

sys/net/if_vxlan.c

Loading...