Differential D36729

netinet*: remove dead code from TCP, UDP, SCTP control input
ClosedPublic
Actions

Authored by glebius on Sep 26 2022, 7:02 PM.

Tags

None

Referenced Files

	F167627112: D36729.id111017.diff
	Sun, Aug 23, 7:25 AM

	Unknown Object (File)
	Tue, Aug 18, 8:28 PM

	Unknown Object (File)
	Tue, Aug 18, 8:00 PM

	Unknown Object (File)
	Tue, Aug 18, 6:01 PM

	Unknown Object (File)
	Tue, Aug 18, 4:27 PM

	Unknown Object (File)
	Tue, Aug 18, 10:18 AM

	Unknown Object (File)
	Tue, Aug 18, 7:48 AM

	Unknown Object (File)
	Tue, Aug 18, 6:40 AM

Subscribers

Details

Reviewers

None

Group Reviewers

network
transport

Commits

rGc0fc81e9138b: netinet*: remove dead code from TCP, UDP, SCTP control input

Summary

Now these functions are called only from icmp*_input(). The pointer to
the ICMP data is never NULL and cmd has a limited set of values.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 47548
Build 44435: arc lint + arc unit

Event Timeline

glebius created this revision.Sep 26 2022, 7:02 PM

Herald added a reviewer: transport. · View Herald TranscriptSep 26 2022, 7:02 PM

Herald added subscribers: melifaro, ae, imp. · View Herald Transcript

glebius requested review of this revision.Sep 26 2022, 7:02 PM

Harbormaster completed remote builds in B47548: Diff 111017.Sep 26 2022, 7:02 PM

glebius added a parent revision: D36728: netinet: filter out invalid ICMP responses in ip_icmp().Sep 26 2022, 7:02 PM

glebius added a child revision: D36730: netipsec: move specific ipsecmethods declarations to ipsec_support.h.

melifaro added inline comments.Oct 3 2022, 5:07 PM

sys/netinet/sctp_usrreq.c
277	Worth mentioning out why we can reference ip+ header fields
281	C99 init?
sys/netinet/tcp_subr.c
2886	Worth clarifying in the description that no one reacts on HOSTDEAD.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 4 2022, 3:58 AM

Closed by commit rGc0fc81e9138b: netinet*: remove dead code from TCP, UDP, SCTP control input (authored by glebius). · Explain Why

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGc0fc81e9138b: netinet*: remove dead code from TCP, UDP, SCTP control input.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

145 lines

95 lines

65 lines

netinet6/

196 lines

88 lines

Diff 111017

sys/netinet/sctp_usrreq.c

Loading...

sys/netinet/tcp_subr.c

Loading...

sys/netinet/udp_usrreq.c

Loading...

sys/netinet6/sctp6_usrreq.c

Loading...

sys/netinet6/udp6_usrreq.c

Loading...