Page MenuHomeFreeBSD
Differential D36697

arm64: Handle 1GB mappings in pmap_enter_quick_locked()
ClosedPublic
Actions

Authored by markj on Sep 25 2022, 2:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 2, 6:57 AM
Unknown Object (File)
Fri, Mar 27, 1:51 PM
Unknown Object (File)
Fri, Mar 27, 3:51 AM
Unknown Object (File)
Thu, Mar 26, 10:21 PM
Unknown Object (File)
Thu, Mar 26, 2:00 PM
Unknown Object (File)
Thu, Mar 26, 11:03 AM
Unknown Object (File)
Sun, Mar 15, 9:47 PM
Unknown Object (File)
Sun, Mar 15, 5:32 AM
View All Files
Subscribers
emaste
imp

Details

Reviewers
alc
kib
andrew
manu
Commits
rG7533062ae133: arm64: Handle 1GB mappings in pmap_enter_quick_locked()

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 47523
Build 44410: arc lint + arc unit

Event Timeline

markj created this revision.Sep 25 2022, 2:51 PM
Herald added a reviewer: manu. · View Herald TranscriptSep 25 2022, 2:51 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
markj requested review of this revision.Sep 25 2022, 2:51 PM
Harbormaster completed remote builds in B47523: Diff 110949.Sep 25 2022, 2:51 PM
markj added a child revision: D36698: arm64: Fix an assertion in pmap_enter_largepage().Sep 25 2022, 2:51 PM
alc accepted this revision.Sep 25 2022, 5:55 PM
alc added inline comments.
sys/arm64/arm64/pmap.c
4598

I wish we had pmap_X_to_X+1() variants that returned the PTE value rather than its address so that we didn't repeatedly pmap_load() afterwards.

This revision is now accepted and ready to land.Sep 25 2022, 5:55 PM
kib accepted this revision.Sep 25 2022, 6:01 PM
markj added inline comments.Sep 25 2022, 7:20 PM
sys/arm64/arm64/pmap.c
4598

Maybe something following this example?

pd_entry_t
pmap_l1e_to_l2e(pdp_entry_t l1e, vm_offset_t va)
{
    pd_entry_t *l2;

    l2 = (pd_entry_t *)PHYS_TO_DMAP(l1e & ~ATTR_MASK);
    return (l2[pmap_l2_index(va)]);
}

On the other hand, I'm not really sure why the arm64 pmap uses pmap_load() to begin with.

Closed by commit rG7533062ae133: arm64: Handle 1GB mappings in pmap_enter_quick_locked() (authored by markj). · Explain WhySep 26 2022, 1:03 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG7533062ae133: arm64: Handle 1GB mappings in pmap_enter_quick_locked().
alc added inline comments.Sep 26 2022, 5:04 PM
sys/arm64/arm64/pmap.c
4598

Yes, something like that.

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
44 lines

Diff 110949

View Options

sys/arm64/arm64/pmap.c

Loading...