Differential D36197

routing: retire rib_lookup_info()
ClosedPublic
Actions

Authored by melifaro on Aug 14 2022, 10:44 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Aug 26, 8:27 AM

	Unknown Object (File)
	Wed, Aug 26, 6:37 AM

	Unknown Object (File)
	Wed, Aug 26, 3:06 AM

	Unknown Object (File)
	Fri, Aug 21, 8:37 PM

	Unknown Object (File)
	Fri, Aug 21, 8:36 PM

	Unknown Object (File)
	Thu, Aug 13, 12:40 PM

	Unknown Object (File)
	Thu, Aug 13, 4:20 AM

	Unknown Object (File)
	Tue, Aug 11, 11:30 PM

Subscribers

Details

Reviewers

None

Group Reviewers

Commits

rG036f1bc6139e: routing: retire rib_lookup_info()

Summary

This function was added in pre-epoch era ( 9a1b64d5a0224 ) to
provide public rtentry access interface & hide rtentry internals.
The implementation is based on the large on-stack copying and
refcounting of the referenced objects (ifa/ifp).
It has become obsolete after epoch & nexthop introduction. Convert
the last remaining user and remove the function itself.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 46933
Build 43822: arc lint + arc unit

Event Timeline

melifaro created this revision.Aug 14 2022, 10:44 AM

Herald added subscribers: glebius, ae, imp. · View Herald TranscriptAug 14 2022, 10:44 AM

melifaro requested review of this revision.Aug 14 2022, 10:44 AM

Harbormaster completed remote builds in B46933: Diff 109321.Aug 14 2022, 10:45 AM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 15 2022, 6:49 AM

Closed by commit rG036f1bc6139e: routing: retire rib_lookup_info() (authored by melifaro). · Explain Why

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rG036f1bc6139e: routing: retire rib_lookup_info().

Revision Contents
Changeset List

Path

Size

sys/

net/

3 lines

145 lines

19 lines

Diff 109321

sys/net/route.h

Loading...

sys/net/route.c

Loading...

sys/net/rtsock.c

Loading...