vnet: make VNET_FOREACH() always be a loop
ClosedPublic
Actions

Authored by kp on Jul 6 2022, 8:21 PM.

Details

Reviewers

glebius
melifaro

Group Reviewers

network
pfsense

Commits

rG37f604b49d4a: vnet: make VNET_FOREACH() always be a loop

Summary

VNET_FOREACH() is a LIST_FOREACH if VIMAGE is set, but empty if it's
not. This means that users of the macro couldn't use 'continue' or
'break' as one would expect of a loop.

Change VNET_FOREACH() to be a loop in all cases (although one that is
fixed to one iteration if VIMAGE is not set).

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 46301
Build 43190: arc lint + arc unit

Event Timeline

kp created this revision.Jul 6 2022, 8:21 PM

Herald added subscribers: glebius, melifaro, ae, imp. · View Herald TranscriptJul 6 2022, 8:21 PM

kp requested review of this revision.Jul 6 2022, 8:21 PM

Harbormaster completed remote builds in B46301: Diff 107863.Jul 6 2022, 8:21 PM

I wonder if compiler removes the loop and produces same code after the change.

This revision is now accepted and ready to land.Jul 6 2022, 8:28 PM

melifaro accepted this revision.Jul 6 2022, 9:07 PM

In D35739#810676, @glebius wrote:

I wonder if compiler removes the loop and produces same code after the change.

It does, yes, so this is a no-op, other than making the loop work the way a reader would expect it to, regardless of VIMAGE or ! VIMAGE.

Closed by commit rG37f604b49d4a: vnet: make VNET_FOREACH() always be a loop (authored by kp). · Explain WhyJul 7 2022, 8:45 AM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG37f604b49d4a: vnet: make VNET_FOREACH() always be a loop.

Revision Contents
Changeset List

Path

Size

sys/

net/

vnet.h

2 lines

Diff 107863

View Options

vnet: make VNET_FOREACH() always be a loopClosedPublicActions