Page MenuHomeFreeBSD

vnet: make VNET_FOREACH() always be a loop
ClosedPublic

Authored by kp on Jul 6 2022, 8:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 6 2026, 10:22 PM
Unknown Object (File)
May 1 2026, 10:14 AM
Unknown Object (File)
Apr 29 2026, 12:03 AM
Unknown Object (File)
Apr 28 2026, 12:32 PM
Unknown Object (File)
Apr 28 2026, 10:28 AM
Unknown Object (File)
Apr 27 2026, 11:44 AM
Unknown Object (File)
Apr 27 2026, 2:37 AM
Unknown Object (File)
Apr 26 2026, 3:32 PM

Details

Summary

VNET_FOREACH() is a LIST_FOREACH if VIMAGE is set, but empty if it's
not. This means that users of the macro couldn't use 'continue' or
'break' as one would expect of a loop.

Change VNET_FOREACH() to be a loop in all cases (although one that is
fixed to one iteration if VIMAGE is not set).

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp requested review of this revision.Jul 6 2022, 8:21 PM

I wonder if compiler removes the loop and produces same code after the change.

This revision is now accepted and ready to land.Jul 6 2022, 8:28 PM

I wonder if compiler removes the loop and produces same code after the change.

It does, yes, so this is a no-op, other than making the loop work the way a reader would expect it to, regardless of VIMAGE or ! VIMAGE.

This revision was automatically updated to reflect the committed changes.