SACK rescue retransmission is supposed to be inserted never
exceeding the right edge of the socket sendbuffer. However,
rarely there appear to be instances, when either the rescue
retransmission is created using an incorrect offset (FIN bit?),
or the send buffer retracts (?). In this case, panic an INVARIANTS
kernel as early as possible to track why this may be happening,
or skip over SACK retransmission processing altogether and revert
to NewReno loss recovery from snd_una.
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 46106 Build 42995: arc lint + arc unit
Event Timeline
| sys/netinet/tcp_output.c | ||
|---|---|---|
| 1574 | Please declare so at the beginning of a block. | |
| 1577 | Use top + 1 instead of top+1. | |
| 1659 | Please declare so at the beginning of a block. | |
| sys/netinet/tcp_sack.c | ||
| 903–915 | Please declare so at the beginning of a block. | |
| 987–988 | Why do you start a block here? | |
| 988 | Please declare so at the beginning of a block; assuming you remove the start of the current block. | |