Paths

Table of Contentst

Fix offset computation
ClosedPublic
Actions

Authored by tuexen on Sep 18 2022, 11:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Mar 22, 3:21 PM

	Unknown Object (File)
	Tue, Mar 17, 6:54 AM

	Unknown Object (File)
	Fri, Mar 13, 5:40 PM

	Unknown Object (File)
	Thu, Mar 12, 11:52 PM

	Unknown Object (File)
	Sun, Mar 8, 6:03 AM

	Unknown Object (File)
	Mar 1 2026, 10:12 PM

	Unknown Object (File)
	Feb 27 2026, 12:17 AM

	Unknown Object (File)
	Feb 26 2026, 1:41 PM

Subscribers

Details

Reviewers

rrs
rscheff

Group Reviewers

transport

Commits

rG0612d3000b97: tcp: fix computation of offset
rG26370413d43b: tcp: fix computation of offset
rG6d9e911fbadf: tcp: fix computation of offset

Summary

Only update off if we are actually retransmitting from the scoreboard.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Sep 18 2022, 11:16 PM

Herald added a reviewer: transport. · View Herald TranscriptSep 18 2022, 11:16 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript

tuexen requested review of this revision.Sep 18 2022, 11:16 PM

rscheff accepted this revision.Sep 19 2022, 9:27 AM

This revision is now accepted and ready to land.Sep 19 2022, 9:27 AM

Closed by commit rG6d9e911fbadf: tcp: fix computation of offset (authored by tuexen). · Explain WhySep 19 2022, 10:50 AM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rG6d9e911fbadf: tcp: fix computation of offset.

rscheff added a commit: rG26370413d43b: tcp: fix computation of offset.Sep 25 2022, 10:05 AM

rscheff added a commit: rG0612d3000b97: tcp: fix computation of offset.

rscheff mentioned this in D35446: tcp: Check if we exceed socket send buffer instead of snd_fack.Sep 29 2022, 7:52 AM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_output.c

6 lines

Diff 110724

View Options

Fix offset computationClosedPublicActions