Page MenuHomeFreeBSD

routing: fix RTM_CHANGE for multipath #1
ClosedPublic

Authored by melifaro on Jun 19 2022, 8:28 PM.
Tags
None
Referenced Files
F165326317: D35526.id107169.diff
Fri, Aug 7, 4:04 PM
F165321732: D35526.id.diff
Fri, Aug 7, 3:30 PM
F165257358: D35526.id107170.diff
Fri, Aug 7, 5:38 AM
Unknown Object (File)
Thu, Aug 6, 2:31 PM
Unknown Object (File)
Thu, Aug 6, 2:22 PM
Unknown Object (File)
Wed, Aug 5, 6:05 AM
Unknown Object (File)
Sun, Jul 26, 6:41 PM
Unknown Object (File)
Tue, Jul 21, 3:10 AM
Subscribers

Details

Summary

RTM_CHANGE is supposed to operate on a single component of the multipath route (e.g. on a single nexthop). Search of this nexthop is peformed by iterating over each nexthop from multipath (nexthop) group, using check_info_match_nhop. The problem with the current code that it (incorrectly assumes that check_info_match_nhop() returns true value on match, while in reality it returns an error code on failure).
Fix this by properly comparing the result with 0.

Next, the followup code creating a new nexthop group, was modifying original group instead of a new one, leading to the spurious errors.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46033
Build 42922: arc lint + arc unit