Page MenuHomeFreeBSD

routing: fix RTM_CHANGE for multipath #1
ClosedPublic

Authored by melifaro on Jun 19 2022, 8:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 27, 5:51 PM
Unknown Object (File)
Sat, Apr 27, 5:51 PM
Unknown Object (File)
Sat, Apr 27, 5:51 PM
Unknown Object (File)
Sat, Apr 27, 5:51 PM
Unknown Object (File)
Sat, Apr 27, 4:29 PM
Unknown Object (File)
Mar 22 2024, 9:29 PM
Unknown Object (File)
Mar 22 2024, 9:29 PM
Unknown Object (File)
Mar 22 2024, 9:29 PM
Subscribers

Details

Summary

RTM_CHANGE is supposed to operate on a single component of the multipath route (e.g. on a single nexthop). Search of this nexthop is peformed by iterating over each nexthop from multipath (nexthop) group, using check_info_match_nhop. The problem with the current code that it (incorrectly assumes that check_info_match_nhop() returns true value on match, while in reality it returns an error code on failure).
Fix this by properly comparing the result with 0.

Next, the followup code creating a new nexthop group, was modifying original group instead of a new one, leading to the spurious errors.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46033
Build 42922: arc lint + arc unit