libsecureboot: Do not propagate empty string
ClosedPublic
Actions

Authored by hum_semihalf.com on May 4 2022, 11:57 AM.

Details

Reviewers

mw
wma
sjg

Commits

rG9c95cd930378: libsecureboot: Do not propagate empty string
rGe6ef5042e485: libsecureboot: Do not propagate empty string

Summary

If Trust Anchors are provided by UEFI and not compiled into
libsecureboot the segmentation fault occurs due to empty
or NULL string usage.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

hum_semihalf.com created this revision.May 4 2022, 11:57 AM

Herald added subscribers: dab, imp. · View Herald TranscriptMay 4 2022, 11:57 AM

hum_semihalf.com requested review of this revision.May 4 2022, 11:57 AM

sjg added inline comments.May 6 2022, 4:15 PM

lib/libsecureboot/vets.c
425	you miss out on OpenPGP support?

Do not return immediately in case TRUST ANCHORS are NULL, as openpgp may be supported as well.

sjg accepted this revision.May 13 2022, 5:59 PM

This revision is now accepted and ready to land.May 13 2022, 5:59 PM

Rebase the revision.

This revision now requires review to proceed.May 16 2022, 5:23 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 29 2022, 8:51 AM

Closed by commit rGe6ef5042e485: libsecureboot: Do not propagate empty string (authored by wma). · Explain Why

This revision was automatically updated to reflect the committed changes.

wma added a commit: rGe6ef5042e485: libsecureboot: Do not propagate empty string.

gbe added a commit: rG9c95cd930378: libsecureboot: Do not propagate empty string.Apr 14 2023, 7:26 AM

Revision Contents
Changeset List

Path

Size

lib/

libsecureboot/

vets.c

5 lines

Diff 105780

View Options

libsecureboot: Do not propagate empty stringClosedPublicActions