Page MenuHomeFreeBSD
Differential D34960

Fill the page size array in one posix shm test
ClosedPublic
Actions

Authored by andrew on Apr 19 2022, 4:26 PM.
Tags
None
Referenced Files
F105498802: D34960.id105169.diff
Mon, Dec 16, 11:16 PM
Unknown Object (File)
Sun, Dec 8, 2:21 AM
Unknown Object (File)
Nov 16 2024, 5:55 PM
Unknown Object (File)
Sep 21 2024, 11:48 AM
Unknown Object (File)
Sep 21 2024, 6:27 AM
Unknown Object (File)
Sep 20 2024, 3:56 PM
Unknown Object (File)
Sep 19 2024, 2:57 AM
Unknown Object (File)
Sep 17 2024, 3:58 AM
View All 54 Files
Subscribers
imp

Details

Reviewers
markj
kevans
kib
jhb
Commits
rG05d173587b1f: Fill the page size array in one posix shm test
Summary

The largepage_config posix shared memory test was failing on arm64 as
the page size array is never filled out. Fix this by calling
getpagesizes(3).

While here skip the test if there is no support for superpages.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45227
Build 42115: arc lint + arc unit

Event Timeline

andrew created this revision.Apr 19 2022, 4:26 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 19 2022, 4:26 PM
andrew requested review of this revision.Apr 19 2022, 4:26 PM
Harbormaster completed remote builds in B45225: Diff 105169.Apr 19 2022, 4:26 PM
markj added inline comments.Apr 19 2022, 4:42 PM
tests/sys/posixshm/posixshm_test.c
1258

pagesizes() already checks this.

markj added inline comments.Apr 19 2022, 4:46 PM
tests/sys/posixshm/posixshm_test.c
1258

I suspect it should just be (void)pagesizes(ps), to avoid reintroducing the warning that was fixed by cd16a848d1b34016b1a1c663223729a92c247be3.

andrew updated this revision to Diff 105171.Apr 19 2022, 4:47 PM

Remove the page size check

Harbormaster completed remote builds in B45227: Diff 105171.Apr 19 2022, 4:47 PM
andrew marked 2 inline comments as done.Apr 19 2022, 4:49 PM
andrew added inline comments.
tests/sys/posixshm/posixshm_test.c
1258

I agree, I'd already changed to that before seeing your second comment.

markj accepted this revision.Apr 19 2022, 4:58 PM
This revision is now accepted and ready to land.Apr 19 2022, 4:58 PM
kib accepted this revision.Apr 19 2022, 8:44 PM
Closed by commit rG05d173587b1f: Fill the page size array in one posix shm test (authored by andrew). · Explain WhyApr 20 2022, 1:45 PM
This revision was automatically updated to reflect the committed changes.
andrew marked an inline comment as done.
andrew added a commit: rG05d173587b1f: Fill the page size array in one posix shm test.

Revision Contents
Changeset List

PathSize
tests/
sys/
posixshm/
2 lines

Diff 105171

View Options

tests/sys/posixshm/posixshm_test.c

Loading...