Page MenuHomeFreeBSD

Fill the page size array in one posix shm test
ClosedPublic

Authored by andrew on Apr 19 2022, 4:26 PM.
Tags
None
Referenced Files
F105582234: D34960.diff
Tue, Dec 17, 10:38 PM
F105498802: D34960.id105169.diff
Mon, Dec 16, 11:16 PM
Unknown Object (File)
Sun, Dec 8, 2:21 AM
Unknown Object (File)
Nov 16 2024, 5:55 PM
Unknown Object (File)
Sep 21 2024, 11:48 AM
Unknown Object (File)
Sep 21 2024, 6:27 AM
Unknown Object (File)
Sep 20 2024, 3:56 PM
Unknown Object (File)
Sep 19 2024, 2:57 AM
Subscribers

Details

Summary

The largepage_config posix shared memory test was failing on arm64 as
the page size array is never filled out. Fix this by calling
getpagesizes(3).

While here skip the test if there is no support for superpages.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45225
Build 42113: arc lint + arc unit

Event Timeline

tests/sys/posixshm/posixshm_test.c
1258

pagesizes() already checks this.

tests/sys/posixshm/posixshm_test.c
1258

I suspect it should just be (void)pagesizes(ps), to avoid reintroducing the warning that was fixed by cd16a848d1b34016b1a1c663223729a92c247be3.

Remove the page size check

andrew added inline comments.
tests/sys/posixshm/posixshm_test.c
1258

I agree, I'd already changed to that before seeing your second comment.

This revision is now accepted and ready to land.Apr 19 2022, 4:58 PM
This revision was automatically updated to reflect the committed changes.
andrew marked an inline comment as done.