Page MenuHomeFreeBSD
Differential D34803

Remove checks for __CC_SUPPORTS_WARNING assuming it is always true.
ClosedPublic
Actions

Authored by jhb on Apr 6 2022, 2:26 PM.
Tags
None
Referenced Files
F167833819: D34803.id104669.diff
Mon, Aug 24, 9:04 PM
F167761057: D34803.diff
Mon, Aug 24, 8:46 AM
F167743988: D34803.id.diff
Mon, Aug 24, 5:27 AM
Unknown Object (File)
Sun, Aug 9, 6:54 PM
Unknown Object (File)
Sun, Aug 9, 6:26 PM
Unknown Object (File)
Sun, Aug 9, 6:25 PM
Unknown Object (File)
Sun, Aug 9, 7:47 AM
Unknown Object (File)
Tue, Aug 4, 9:05 AM
View All Files
Subscribers
andrew
imp
jhibbits

Details

Reviewers
brooks
emaste
imp
Commits
rG5f9c9ae2f22b: Remove checks for __CC_SUPPORTS_WARNING assuming it is always true.
Summary

All supported compilers (modern versions of GCC and clang) support
this.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45028
Build 41916: arc lint + arc unit

Event Timeline

jhb created this revision.Apr 6 2022, 2:26 PM
Herald added subscribers: jhibbits, andrew, imp. · View Herald TranscriptApr 6 2022, 2:26 PM
jhb requested review of this revision.Apr 6 2022, 2:26 PM
Harbormaster completed remote builds in B45028: Diff 104669.Apr 6 2022, 2:26 PM
jhb added a parent revision: D34802: Remove checks for __CC_SUPPORTS__INLINE assuming it is always true..Apr 6 2022, 2:26 PM
jhb added a child revision: D34804: Remove checks for <sys/cdefs.h> being included..
imp accepted this revision.Apr 6 2022, 2:38 PM
This revision is now accepted and ready to land.Apr 6 2022, 2:38 PM
brooks accepted this revision.Apr 8 2022, 9:25 PM

This one is perhaps the most debatable one since #warning isn't standard, but we've got plenty of unguarded uses.

It's probably time to finish off machine/speaker.h and machine/limits.h (or at least do an exp-run to see how bad it is)

Closed by commit rG5f9c9ae2f22b: Remove checks for __CC_SUPPORTS_WARNING assuming it is always true. (authored by jhb). · Explain WhyApr 12 2022, 5:13 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG5f9c9ae2f22b: Remove checks for __CC_SUPPORTS_WARNING assuming it is always true..

Revision Contents
Changeset List

PathSize
sys/
amd64/
include/
4 lines
arm/
include/
4 lines
i386/
include/
4 lines
4 lines
powerpc/
include/
4 lines
sys/
5 lines

Diff 104669

View Options

sys/amd64/include/limits.h

Loading...
View Options

sys/arm/include/limits.h

Loading...
View Options

sys/i386/include/limits.h

Loading...
View Options

sys/i386/include/speaker.h

Loading...
View Options

sys/powerpc/include/limits.h

Loading...
View Options

sys/sys/syslimits.h

Loading...