Page MenuHomeFreeBSD
Differential D34681

add pidfile_signal and use it in mount
ClosedPublic
Actions

Authored by mjg on Mar 26 2022, 8:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 1:33 PM
Unknown Object (File)
Tue, Apr 30, 1:33 PM
Unknown Object (File)
Tue, Apr 30, 1:33 PM
Unknown Object (File)
Tue, Apr 30, 1:33 PM
Unknown Object (File)
Tue, Apr 30, 1:33 PM
Unknown Object (File)
Tue, Apr 30, 1:33 PM
Unknown Object (File)
Tue, Apr 30, 7:14 AM
Unknown Object (File)
Mar 8 2024, 3:27 AM
View All 51 Files
Subscribers
imp
rew

Details

Reviewers
None
Commits
rGa3214fbe7fff: mount: use pidfile_signal
rG287451fd0192: pidfile: add pidfile_signal
Summary

this fixes a performance problem where poudriere -j 104 keeps remounting filesystems, which induce wanting to signal mountd, if running. the current code tries to do it by creating the pidfile in /var/run and unlinking it if the operation succeeds. this induces contention against anything doing an exec as it tries to look up /var/run/ld-elf.so.hints

commit 963072c7bae56d6f4d53f52daab6ca23eecff487 (HEAD -> pidfile)
Author: Mateusz Guzik <mjg@FreeBSD.org>
Date:   Fri Mar 11 11:02:28 2022 +0000

    mount: use pidfile_signal

commit 2796d6df18f81e69ee22d43528e275c9cfe3be47
Author: Mateusz Guzik <mjg@FreeBSD.org>
Date:   Fri Mar 11 11:01:50 2022 +0000

    pidfile: add pidfile_signal
Test Plan

started mountd and verified it gets signalled, if running

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mjg requested review of this revision.Mar 26 2022, 8:22 PM
mjg created this revision.
mjg edited the test plan for this revision. (Show Details)
mjg updated this revision to Diff 104237.Mar 26 2022, 8:24 PM
mjg updated this revision to Diff 104238.
rew added a subscriber: rew.Mar 30 2022, 9:17 PM
/usr/src/lib/libutil/pidfile.c:369:2: error: implicit declaration of function 'kill' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        kill(pid, sig);

Missing <signal.h>, <sys/types.h>?

mjg updated this revision to Diff 104403.Mar 31 2022, 11:17 AM
  • add missing headers
Herald added a subscriber: imp. · View Herald TranscriptMar 31 2022, 11:17 AM
This revision was not accepted when it landed; it landed in state Needs Review.Apr 9 2022, 4:02 PM
Closed by commit rG287451fd0192: pidfile: add pidfile_signal (authored by mjg). · Explain Why
This revision was automatically updated to reflect the committed changes.
mjg added a commit: rG287451fd0192: pidfile: add pidfile_signal.
mjg added a commit: rGa3214fbe7fff: mount: use pidfile_signal.

Revision Contents
Changeset List

PathSize
lib/
libutil/
1 line
68 lines
sbin/
mount/
27 lines
sys/
sys/
2 lines

Diff 104237

View Options

lib/libutil/libutil.h

Loading...
View Options

lib/libutil/pidfile.c

Loading...
View Options

sbin/mount/mount.c

Loading...
View Options

sys/sys/mount.h

Loading...