Make page size dynamic in libkvm for arm64
ClosedPublic
Actions

Authored by andrew on Mar 14 2022, 2:41 PM.

Details

Reviewers

markj
kib
jhb
imp
manu

Group Reviewers

arm64

Commits

rGf2e36d47e3be: Make page size dynamic in libkvm for arm64

Summary

To allow for a future 16k or 64k page size we need to tell libkvm which
is being used. Add a flag field in unused space in minidumphdr and use
it to signal between the different options.

Test Plan

Kua tests pass & w -M <core> works

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Mar 14 2022, 2:41 PM

Herald added a reviewer: manu. · View Herald TranscriptMar 14 2022, 2:41 PM

Herald added a subscriber: emaste. · View Herald Transcript

andrew requested review of this revision.Mar 14 2022, 2:41 PM

Harbormaster completed remote builds in B44763: Diff 103826.Mar 14 2022, 2:41 PM

markj added inline comments.Mar 14 2022, 4:04 PM

lib/libkvm/kvm_minidump_aarch64.c
51	The line break doesn't seem to be needed.
108	Is it supposed to be `vmst->hdr.version < 1`?
188–190	Maybe define aarch64_trunc_page() to complement aarch64_round_page().