Page MenuHomeFreeBSD
Differential D34545

Chase mixer(8) command-line interface changes
ClosedPublic
Actions

Authored by 0mp on Mar 13 2022, 1:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 18, 1:47 AM
Unknown Object (File)
Feb 7 2024, 4:44 PM
Unknown Object (File)
Jan 9 2024, 4:46 AM
Unknown Object (File)
Dec 12 2023, 1:14 AM
Unknown Object (File)
Nov 14 2023, 11:41 PM
Unknown Object (File)
Nov 13 2023, 1:13 AM
Unknown Object (File)
Nov 10 2023, 6:59 AM
Unknown Object (File)
Nov 10 2023, 3:56 AM
View All 34 Files
Subscribers
asomers
debdrup
imp
pauamma_gundo.com

Details

Reviewers
• hselasky
christos
Group Reviewers
manpages
multimedia
Commits
rGd5ad1713cc38: Chase mixer(8) command-line interface changes
rGe83a53abeb90: Chase mixer(8) command-line interface changes
Summary

FreeBSD 14.0 is going to ship with a new implementation of the mixer(8)
command. Unfortunately, in order to support new features like mute, the
command-line interface of the new implementation is not backwards
compatible.

Update all the remaining documentation and scripts in the src tree
to use the new syntax.

While here, document in usbhidaction.1 that the mute functionality is
now supported.

Fixes: 903873ce1560 Implement and use new mixer(3) library for FreeBSD.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

0mp created this revision.Mar 13 2022, 1:20 PM
Herald added a reviewer: manpages. · View Herald TranscriptMar 13 2022, 1:20 PM
Herald added subscribers: asomers, imp. · View Herald Transcript
0mp requested review of this revision.Mar 13 2022, 1:20 PM
Harbormaster completed remote builds in B44760: Diff 103805.Mar 13 2022, 1:20 PM
0mp added reviewers: • hselasky, christos.Mar 13 2022, 1:22 PM
0mp added a reviewer: multimedia.Mar 13 2022, 1:31 PM
• hselasky accepted this revision.Mar 13 2022, 1:45 PM

Looks good. Thank you!

This revision is now accepted and ready to land.Mar 13 2022, 1:45 PM
christos added a comment.Mar 13 2022, 2:22 PM

LGTM!

christos accepted this revision.Mar 13 2022, 2:22 PM
debdrup accepted this revision as: manpages.Mar 13 2022, 3:38 PM
debdrup added a subscriber: debdrup.

The mdoc syntax looks good to me.

Thank you for doing this, as it was on my TODO list but kept getting pushed down.

0mp added a comment.Mar 13 2022, 4:44 PM

Thanks!

Closed by commit rGe83a53abeb90: Chase mixer(8) command-line interface changes (authored by 0mp). · Explain WhyMar 13 2022, 4:44 PM
This revision was automatically updated to reflect the committed changes.
0mp added a commit: rGe83a53abeb90: Chase mixer(8) command-line interface changes.
pauamma_gundo.com added a subscriber: pauamma_gundo.com.Mar 14 2022, 12:25 AM
pauamma_gundo.com added inline comments.
usr.bin/usbhidaction/usbhidaction.1
144

Is the command on that line correct? "^" (and maybe "mute.volume") doesn't look consistent with devd configuration files or acpi_ibm(4) above.

• hselasky added inline comments.Mar 14 2022, 8:27 AM
sbin/devd/apple.conf
47

mixer vol.mute=^1

usr.bin/usbhidaction/usbhidaction.1
144

You are right, should be vol.mute=^

@0mp : Will you fix?

• hselasky added inline comments.Mar 14 2022, 8:34 AM
sbin/devd/apple.conf
47

mixer vol.mute=^

• hselasky added a comment.Mar 14 2022, 8:35 AM

I'll take it.

• hselasky added a commit: rGd5ad1713cc38: Chase mixer(8) command-line interface changes.Mar 14 2022, 8:39 AM

Revision Contents
Changeset List

PathSize
sbin/
devd/
6 lines
12 lines
share/
man/
man4/
6 lines
usr.bin/
fortune/
datfiles/
4 lines
usbhidaction/
19 lines

Diff 103807

View Options

sbin/devd/apple.conf

Loading...
View Options

sbin/devd/asus.conf

Loading...
View Options

share/man/man4/acpi_ibm.4

Loading...
View Options

usr.bin/fortune/datfiles/freebsd-tips

Loading...
View Options

usr.bin/usbhidaction/usbhidaction.1

Loading...