Add support for --help and --version to be compatible with gnu diff.
gnu diff --help writes to stdout, do the same to be compatible
Details
Details
- Reviewers
bapt pstef - Group Reviewers
Klara manpages - Commits
- rG8cf449db88b2: diff: add support for --help and --version
Test suite was run and no failures found
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 44731 Build 41619: arc lint + arc unit
Event Timeline
Comment Actions
A tiny nit with the mdoc syntax, otherwise it looks good to me.
| usr.bin/diff/diff.1 | ||
|---|---|---|
| 316 | A macro missed its stop on the chair-keyboard bus. ;) | |
| usr.bin/diff/diff.1 | ||
|---|---|---|
| 289 | Worth mentioning "to standard output"? I'm on the fence on this. | |
| 316 |
Or maybe 2 collided causing a wreck. gdiff(1) says "-v, --version" | |
| 317 | Same question as for --help. | |
| usr.bin/diff/diff.c | ||
| 56 | For full compatibility, also needs to support -v as a --version synonym here and *gestures vaguely toward the switch statement below* | |
Comment Actions
I can only see the man-page change, should I be seeing code changes in this diff as well?
Comment Actions
Yeah, wrong diff point with arc diff, I am sure arcanist wasn't this much trouble to use before