Paths

Table of Contentst

Differential D34300

nvme: Add OAES bit-field definitions
ClosedPublic
Actions

Authored by chuck on Feb 16 2022, 2:58 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Sep 10, 7:12 PM

	Unknown Object (File)
	Sun, Sep 6, 2:25 PM

	Unknown Object (File)
	Sun, Sep 6, 9:28 AM

	Unknown Object (File)
	Sun, Sep 6, 1:01 AM

	Unknown Object (File)
	Sun, Sep 6, 12:41 AM

	Unknown Object (File)
	Sat, Sep 5, 11:00 PM

	Unknown Object (File)
	Sat, Sep 5, 10:57 PM

	Unknown Object (File)
	Sat, Sep 5, 8:39 PM

Subscribers

Details

Reviewers

imp
mav

Commits

rGe71afa120275: nvme: Add OAES bit-field definitions

Summary

Create definitions for the Optional Asynchronous Events Supported (OAES)
values. Also adds a helper macro for the common use case of "mask and
shift". E.g.

value = NVME_CTRLR_DATA_OAES_NS_ATTR_MASK << NVME_CTRLR_DATA_OAES_NS_ATTR_SHIFT;

becomes

value = NVMEB(NVME_CTRLR_DATA_OAES_NS_ATTR);

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 44513
Build 41401: arc lint + arc unit

Event Timeline

chuck created this revision.Feb 16 2022, 2:58 PM

Herald added a subscriber: dab. · View Herald TranscriptFeb 16 2022, 2:58 PM

chuck requested review of this revision.Feb 16 2022, 2:58 PM

Harbormaster completed remote builds in B44478: Diff 102840.Feb 16 2022, 2:58 PM

The new OAES defines are probably fine, but I'd like some feedback on the NVMEB() helper macro. Do you like it? Hate it? Have a better approach? Better name?

Looks good to me, I just think we could add more while there.

sys/dev/nvme/nvme.h
257	Where is the mask for the bit 14? Looking on NVMe 2.0 spec I see few more bits here. Why not add them too?

Added missing mask for Endurance Group (bit 14) and added new
definitions from the 2.0 specification

Harbormaster completed remote builds in B44513: Diff 102989.Feb 20 2022, 3:03 PM

mav accepted this revision.Feb 20 2022, 10:30 PM

This revision is now accepted and ready to land.Feb 20 2022, 10:30 PM

imp accepted this revision.Feb 21 2022, 12:32 AM

chuck mentioned this in D32953: bhyve nvme: Inform guests of namespace resize.Feb 21 2022, 3:20 PM

Closed by commit rGe71afa120275: nvme: Add OAES bit-field definitions (authored by chuck). · Explain WhyFeb 21 2022, 6:54 PM

This revision was automatically updated to reflect the committed changes.

chuck added a commit: rGe71afa120275: nvme: Add OAES bit-field definitions.

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvme/

32 lines

Diff 102989

sys/dev/nvme/nvme.h

Loading...