Differential D34303

Integrate contrib/file/tests with kyua/atf
ClosedPublic
Actions

Authored by vangyzen on Feb 16 2022, 4:04 PM.

Tags

None

Referenced Files

	F105714890: D34303.id102848.diff
	Thu, Dec 19, 2:53 PM

	F105707781: D34303.diff
	Thu, Dec 19, 12:23 PM

	Unknown Object (File)
	Mon, Dec 2, 8:38 PM

	Unknown Object (File)
	Thu, Nov 28, 6:17 AM

	Unknown Object (File)
	Sun, Nov 24, 9:44 PM

	Unknown Object (File)
	Sun, Nov 24, 3:42 AM

	Unknown Object (File)
	Sat, Nov 23, 1:41 AM

	Unknown Object (File)
	Wed, Nov 20, 12:04 PM

View All 89 Files

Subscribers

Details

Reviewers

delphij
eadler
ngie

Commits

rG22561b00abac: Integrate contrib/file/tests with kyua/atf
rG1581ec9a4502: Integrate contrib/file/tests with kyua/atf

Summary

This could be done better by making each test a separate ATF test case.
This exercise is left for the reader.

MFC after: 1 week
Sponsored by: Dell EMC Isilon

Test Plan

$ pwd
/usr/tests/usr.bin/file

$ kyua test
file_test:contrib_file_tests  ->  passed  [0.281s]

Results file id is usr_tests_usr.bin_file.20220216-155405-724728
Results saved to /home/vangyzen/.kyua/store/results.usr_tests_usr.bin_file.20220216-155405-724728.db

1/1 passed (0 failed)

$ ls | wc -l
     103

$ du -shA
181K	.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 44481
Build 41369: arc lint + arc unit

Event Timeline

vangyzen created this revision.Feb 16 2022, 4:04 PM

Herald added subscribers: dab, badger, imp. · View Herald TranscriptFeb 16 2022, 4:04 PM

vangyzen requested review of this revision.Feb 16 2022, 4:04 PM

Harbormaster completed remote builds in B44481: Diff 102845.Feb 16 2022, 4:04 PM

lwhsu added a subscriber: lwhsu.Feb 16 2022, 4:19 PM

delphij accepted this revision.Feb 16 2022, 4:44 PM

This revision is now accepted and ready to land.Feb 16 2022, 4:44 PM

fixup: attach tests to the parent Makefile

This revision now requires review to proceed.Feb 16 2022, 5:47 PM

Harbormaster completed remote builds in B44483: Diff 102848.Feb 16 2022, 5:47 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2022, 7:04 PM

Closed by commit rG1581ec9a4502: Integrate contrib/file/tests with kyua/atf (authored by vangyzen). · Explain Why

This revision was automatically updated to reflect the committed changes.

vangyzen added a commit: rG1581ec9a4502: Integrate contrib/file/tests with kyua/atf.

vangyzen added a commit: rG22561b00abac: Integrate contrib/file/tests with kyua/atf.Mar 2 2022, 10:00 PM

Revision Contents
Changeset List

Path

Size

etc/

mtree/

2 lines

usr.bin/

file/

tests/

8 lines

54 lines

Diff 102845

etc/mtree/BSD.tests.dist

Loading...

usr.bin/file/tests/Makefile

Loading...

usr.bin/file/tests/file_test.sh

Loading...