Differential D34028

sdhci_fsl_fdt: Apply errata for LX2160A
ClosedPublic
Actions

Authored by hum_semihalf.com on Jan 25 2022, 8:35 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jun 25, 2:42 PM

	Unknown Object (File)
	Tue, Jun 24, 3:00 AM

	Unknown Object (File)
	Mon, Jun 23, 1:49 AM

	Unknown Object (File)
	Sun, Jun 22, 1:57 PM

	Unknown Object (File)
	Sat, Jun 21, 8:10 PM

	Unknown Object (File)
	Sat, Jun 21, 4:09 PM

	Unknown Object (File)
	Fri, Jun 20, 2:36 AM

	Unknown Object (File)
	Wed, Jun 11, 4:52 AM

Subscribers

contact_artur-rojek.eu

Details

Reviewers

mw
wma
manu
mmel
imp

Commits

rGcaca7dd08752: sdhci_fsl_fdt: Apply errata for LX2160A

Summary

LX2160A is affected by two erratum regarding SDHCI. However this board
has generic compat string in DTS for SDHCI which means erratum cannot
be simply applied. Compare compat string from "/" path with LX2160A
compat string when attaching device and apply erratum.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

hum_semihalf.com created this revision.Jan 25 2022, 8:35 AM

Herald added a subscriber: imp. · View Herald TranscriptJan 25 2022, 8:35 AM

hum_semihalf.com requested review of this revision.Jan 25 2022, 8:35 AM

kd added a subscriber: kd.Jan 25 2022, 8:38 AM

hum_semihalf.com added a child revision: D34029: sdhci_fsl_fdt: Add voltage switching through syscon.Jan 25 2022, 8:40 AM

hum_semihalf.com added parent revisions: D33981: sdhci_fsl_fdt: Fix pulse width errata application, D34027: sdhci_fsl_fdt: Fix tuning code.

contact_artur-rojek.eu added a subscriber: contact_artur-rojek.eu.Jan 25 2022, 9:17 AM

one nit to check on, otherwise looks OK to me.

sys/dev/sdhci/sdhci_fsl_fdt.c
806	This comment looks misaligned... though that may be an artifact of phab.

This revision is now accepted and ready to land.Jan 28 2022, 12:11 AM

mmel accepted this revision.Jan 31 2022, 9:42 AM

kd mentioned this in D34027: sdhci_fsl_fdt: Fix tuning code.Feb 14 2022, 12:27 PM

Closed by commit rGcaca7dd08752: sdhci_fsl_fdt: Apply errata for LX2160A (authored by hum_semihalf.com, committed by wma). · Explain WhyFeb 22 2022, 8:59 AM

This revision was automatically updated to reflect the committed changes.

wma added a commit: rGcaca7dd08752: sdhci_fsl_fdt: Apply errata for LX2160A.

Revision Contents
Changeset List

Path

Size

sys/

dev/

sdhci/

sdhci_fsl_fdt.c

23 lines

Diff 101890

sys/dev/sdhci/sdhci_fsl_fdt.c

Loading...