pf: postpone clearing of struct pf_pdesc
ClosedPublic
Actions

Authored by kp on Jan 10 2022, 9:20 PM.

Details

Reviewers

mjg
glebius

Group Reviewers

network
pfsense

Commits

rG751d4c7b8728: pf: postpone clearing of struct pf_pdesc

Summary

Postpone zeroing out pd until after the PFI_IFLAG_SKIP/M_SKIP_FIREWALL
checks. We don't need it until then, and it saves us a few CPU cycles in
some cases.
This isn't expected to make a measurable performance change though.

Pointed out by: markj
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43821
Build 40709: arc lint + arc unit

Event Timeline

kp created this revision.Jan 10 2022, 9:20 PM

Herald added subscribers: glebius, melifaro, farrokhi, imp. · View Herald TranscriptJan 10 2022, 9:20 PM

kp requested review of this revision.Jan 10 2022, 9:20 PM

Harbormaster completed remote builds in B43821: Diff 101243.Jan 10 2022, 9:20 PM

kp added a parent revision: D33814: pf: remove PF_TAG_GENERATED.Jan 10 2022, 9:20 PM

The thing to do in the long run is to stop zeroing it upfront to begin with. KMSAN, if operational, can be used to validate there are no uninitialized uses. I tried to do it few weeks back but ran into bugs.

This revision is now accepted and ready to land.Jan 10 2022, 9:44 PM

glebius accepted this revision.Jan 10 2022, 11:37 PM

Closed by commit rG751d4c7b8728: pf: postpone clearing of struct pf_pdesc (authored by kp). · Explain WhyJan 11 2022, 10:17 AM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG751d4c7b8728: pf: postpone clearing of struct pf_pdesc.