pf: remove PF_TAG_GENERATED
ClosedPublic
Actions

Authored by kp on Jan 10 2022, 9:19 PM.

Tags

None

Referenced Files

	F170584700: D33814.id.diff
	Sat, Sep 5, 12:47 PM

	F170484723: D33814.id.diff
	Sat, Sep 5, 1:18 AM

	Unknown Object (File)
	Wed, Sep 2, 5:06 PM

	Unknown Object (File)
	Tue, Sep 1, 4:13 AM

	Unknown Object (File)
	Mon, Aug 31, 4:56 PM

	Unknown Object (File)
	Sat, Aug 29, 4:51 PM

	Unknown Object (File)
	Fri, Aug 28, 3:09 AM

	Unknown Object (File)
	Wed, Aug 26, 12:27 PM

Subscribers

Details

Reviewers

mjg
glebius

Group Reviewers

network
pfsense

Commits

rGecc393594dbe: pf: remove PF_TAG_GENERATED

Summary

It's never set, so we can remove both the check for it and the
definition.

Pointed out by: markj
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Jan 10 2022, 9:19 PM

Herald added subscribers: glebius, melifaro, farrokhi, imp. · View Herald TranscriptJan 10 2022, 9:19 PM

kp requested review of this revision.Jan 10 2022, 9:19 PM

Harbormaster completed remote builds in B43820: Diff 101242.Jan 10 2022, 9:19 PM

kp added a child revision: D33815: pf: postpone clearing of struct pf_pdesc.Jan 10 2022, 9:20 PM

mjg accepted this revision as: mjg.Jan 10 2022, 9:42 PM

mjg added a subscriber: mjg.

mjg added inline comments.

sys/netpfil/pf/pf_mtag.h
39	you should probably denote 0x01 as unused

This revision is now accepted and ready to land.Jan 10 2022, 9:42 PM

mjg accepted this revision as: pfsense.Jan 10 2022, 9:42 PM

glebius accepted this revision.Jan 10 2022, 11:32 PM

Closed by commit rGecc393594dbe: pf: remove PF_TAG_GENERATED (authored by kp). · Explain WhyJan 11 2022, 10:17 AM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGecc393594dbe: pf: remove PF_TAG_GENERATED.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf.c

3 lines

pf_mtag.h

2 lines

Diff 101252

View Options

sys/netpfil/pf/pf.c