Page MenuHomeFreeBSD
Differential D33814

pf: remove PF_TAG_GENERATED
ClosedPublic
Actions

Authored by kp on Jan 10 2022, 9:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 30, 1:54 AM
Unknown Object (File)
Wed, Mar 25, 5:43 AM
Unknown Object (File)
Sat, Mar 21, 12:57 PM
Unknown Object (File)
Tue, Mar 10, 3:48 PM
Unknown Object (File)
Wed, Mar 4, 4:50 AM
Unknown Object (File)
Mar 1 2026, 3:20 PM
Unknown Object (File)
Feb 16 2026, 10:17 PM
Unknown Object (File)
Feb 16 2026, 4:21 PM
View All Files
Subscribers
farrokhi
glebius
imp
melifaro
mjg

Details

Reviewers
mjg
glebius
Group Reviewers
network
pfsense
Commits
rGecc393594dbe: pf: remove PF_TAG_GENERATED
Summary

It's never set, so we can remove both the check for it and the
definition.

Pointed out by: markj
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp created this revision.Jan 10 2022, 9:19 PM
Herald added subscribers: glebius, melifaro, farrokhi, imp. · View Herald TranscriptJan 10 2022, 9:19 PM
kp requested review of this revision.Jan 10 2022, 9:19 PM
Harbormaster completed remote builds in B43820: Diff 101242.Jan 10 2022, 9:19 PM
kp added a child revision: D33815: pf: postpone clearing of struct pf_pdesc.Jan 10 2022, 9:20 PM
mjg accepted this revision as: mjg.Jan 10 2022, 9:42 PM
mjg added a subscriber: mjg.
mjg added inline comments.
sys/netpfil/pf/pf_mtag.h
39

you should probably denote 0x01 as unused

This revision is now accepted and ready to land.Jan 10 2022, 9:42 PM
mjg accepted this revision as: pfsense.Jan 10 2022, 9:42 PM
glebius accepted this revision.Jan 10 2022, 11:32 PM
Closed by commit rGecc393594dbe: pf: remove PF_TAG_GENERATED (authored by kp). · Explain WhyJan 11 2022, 10:17 AM
This revision was automatically updated to reflect the committed changes.
kp added a commit: rGecc393594dbe: pf: remove PF_TAG_GENERATED.

Revision Contents
Changeset List

PathSize
sys/
netpfil/
pf/
3 lines
2 lines

Diff 101252

View Options

sys/netpfil/pf/pf.c

Loading...
View Options

sys/netpfil/pf/pf_mtag.h

Loading...