Page MenuHomeFreeBSD
Differential D33716

Add clarifying comments
ClosedPublic
Actions

Authored by imp on Jan 1 2022, 11:51 PM.
Tags
None
Referenced Files
F169654488: D33716.id100813.diff
Wed, Sep 2, 4:50 AM
F169635484: D33716.id100820.diff
Wed, Sep 2, 3:26 AM
F169632973: D33716.diff
Wed, Sep 2, 3:17 AM
F169615853: D33716.id.diff
Wed, Sep 2, 2:03 AM
Unknown Object (File)
Mon, Aug 31, 3:16 AM
Unknown Object (File)
Mon, Aug 31, 2:56 AM
Unknown Object (File)
Mon, Aug 31, 2:50 AM
Unknown Object (File)
Mon, Aug 31, 2:15 AM
View All Files
Subscribers
bdrewery
emaste

Details

Reviewers
emaste
Commits
rGe0281204cce3: Add clarifying comments
Summary

Expand on the terse comments for where each of these files is used.

Also, remove some mips specific stuff from bsd.opts.mk while I'm there.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp created this revision.Jan 1 2022, 11:51 PM
Herald added subscribers: emaste, bdrewery. · View Herald TranscriptJan 1 2022, 11:51 PM
imp requested review of this revision.Jan 1 2022, 11:51 PM
Harbormaster completed remote builds in B43669: Diff 100813.Jan 1 2022, 11:51 PM
imp added a reviewer: emaste.Jan 1 2022, 11:51 PM
emaste accepted this revision.Jan 2 2022, 12:41 AM

Thanks this does clarify the purpose of the files. I'd think the MIPS changes should be an independent commit tho.

share/mk/bsd.opts.mk
102

This should probably go in by itself?

This revision is now accepted and ready to land.Jan 2 2022, 12:41 AM
imp added inline comments.Jan 2 2022, 12:57 AM
share/mk/bsd.opts.mk
102

Agreed. I'd come to the same conclusion...

Closed by commit rGe0281204cce3: Add clarifying comments (authored by imp). · Explain WhyJan 2 2022, 7:32 AM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGe0281204cce3: Add clarifying comments.

Revision Contents
Changeset List

PathSize
share/
mk/
5 lines
4 lines
sys/
conf/
5 lines

Diff 100820

View Options

share/mk/bsd.opts.mk

Loading...
View Options

share/mk/src.opts.mk

Loading...
View Options

sys/conf/kern.opts.mk

Loading...