Differential D33369

rack: rack_do_compressed_ack_processing() can call tcp_drop()
ClosedPublic
Actions

Authored by glebius on Dec 10 2021, 2:47 AM.

Tags

None

Referenced Files

	F115236463: D33369.id99810.diff
	Mon, Apr 21, 5:27 PM

	Unknown Object (File)
	Mon, Apr 21, 8:34 AM

	Unknown Object (File)
	Fri, Apr 18, 4:25 AM

	Unknown Object (File)
	Thu, Apr 17, 12:55 AM

	Unknown Object (File)
	Tue, Apr 15, 7:53 AM

	Unknown Object (File)
	Mar 23 2025, 4:57 AM

	Unknown Object (File)
	Mar 3 2025, 8:45 PM

	Unknown Object (File)
	Feb 26 2025, 6:51 PM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rGdbbcc777de40: rack: rack_do_compressed_ack_processing() can call tcp_drop()

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Dec 10 2021, 2:47 AM

Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptDec 10 2021, 2:47 AM

Herald added subscribers: melifaro, imp. · View Herald Transcript

glebius requested review of this revision.Dec 10 2021, 2:47 AM

Harbormaster completed remote builds in B43275: Diff 99810.Dec 10 2021, 2:47 AM

glebius added a parent revision: D33368: rack: drop connection synchronously, when we can.Dec 10 2021, 2:48 AM

glebius added a child revision: D33370: tcp: TCP output method can request tcp_drop.

You might want to check what rrs@ thinks...

This revision is now accepted and ready to land.Dec 10 2021, 12:06 PM

Rebase, update descr.

This revision now requires review to proceed.Dec 13 2021, 6:15 PM

Harbormaster completed remote builds in B43318: Diff 99951.Dec 13 2021, 6:15 PM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 26 2021, 4:50 PM

Closed by commit rGdbbcc777de40: rack: rack_do_compressed_ack_processing() can call tcp_drop() (authored by glebius). · Explain Why

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGdbbcc777de40: rack: rack_do_compressed_ack_processing() can call tcp_drop().

Revision Contents
Changeset List

Path

Size

sys/

netinet/

tcp_stacks/

3 lines

Diff 100590

sys/netinet/tcp_stacks/rack.c

	Show First 20 Lines • Show All 151 Lines • ▼ Show 20 Lines
	#endif			#endif

	#define muge_warn_printf(sc, fmt, args...) \			#define muge_warn_printf(sc, fmt, args...) \
	device_printf((sc)->sc_ue.ue_dev, "warning: " fmt, ##args)			device_printf((sc)->sc_ue.ue_dev, "warning: " fmt, ##args)

	#define muge_err_printf(sc, fmt, args...) \			#define muge_err_printf(sc, fmt, args...) \
	device_printf((sc)->sc_ue.ue_dev, "error: " fmt, ##args)			device_printf((sc)->sc_ue.ue_dev, "error: " fmt, ##args)

	#define ETHER_IS_ZERO(addr) \
	(!(addr[0] \| addr[1] \| addr[2] \| addr[3] \| addr[4] \| addr[5]))

	#define ETHER_IS_VALID(addr) \			#define ETHER_IS_VALID(addr) \
	(!ETHER_IS_MULTICAST(addr) && !ETHER_IS_ZERO(addr))			(!ETHER_IS_MULTICAST(addr) && !ETHER_IS_ZERO(addr))

	/* USB endpoints. */			/* USB endpoints. */

	enum {			enum {
	MUGE_BULK_DT_RD,			MUGE_BULK_DT_RD,
	MUGE_BULK_DT_WR,			MUGE_BULK_DT_WR,
	▲ Show 20 Lines • Show All 2,114 Lines • Show Last 20 Lines