inpcb: garbage collect INP_LOCK_INIT(), used only once in sctp
ClosedPublic
Actions

Authored by glebius on Dec 17 2021, 7:03 PM.

Details

Reviewers

Group Reviewers

network
transport

Commits

rGafad340a14f8: inpcb: garbage collect INP_LOCK_INIT(), used only once in sctp

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43450
Build 40338: arc lint + arc unit

Event Timeline

glebius created this revision.Dec 17 2021, 7:03 PM

Herald added a reviewer: transport. · View Herald TranscriptDec 17 2021, 7:03 PM

Herald added subscribers: melifaro, imp. · View Herald Transcript

glebius requested review of this revision.Dec 17 2021, 7:03 PM

glebius added a parent revision: D33542: inpcb: use global UMA zones for protocols.

Harbormaster completed remote builds in B43449: Diff 100230.Dec 17 2021, 7:03 PM

tuexen added a subscriber: tuexen.Dec 17 2021, 7:53 PM

tuexen added inline comments.

sys/netinet/sctp_pcb.c
2501	Could you just replace the code here instead of putting it into `SCTP_INP_LOCK_INIT()`?

Re-do per Michael suggestion.

Harbormaster completed remote builds in B43450: Diff 100231.Dec 17 2021, 8:10 PM

glebius marked an inline comment as done.Dec 17 2021, 8:10 PM

tuexen accepted this revision.Dec 17 2021, 8:15 PM

This revision is now accepted and ready to land.Dec 17 2021, 8:15 PM

Closed by commit rGafad340a14f8: inpcb: garbage collect INP_LOCK_INIT(), used only once in sctp (authored by glebius). · Explain WhyJan 3 2022, 6:23 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGafad340a14f8: inpcb: garbage collect INP_LOCK_INIT(), used only once in sctp.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

in_pcb.h

2 lines

sctp_pcb.c

3 lines

Diff 100231

View Options

sys/netinet/in_pcb.h