Tidy up machine dependent Makefiles in libc.
ClosedPublic
Actions

Authored by brooks on Feb 28 2017, 10:10 PM.

Details

Reviewers

jhb
imp
adrian
andrew

Commits

rS315044: MFC r314556-r314558
rS314558: Garbage collect unused gdtoa related files on mips.
rS314557: Correct an misunderstanding of MDSRCS.
rS314556: Correct MDSRCS use in <arch>/string/Makefile.inc.

Summary

Correct MDSRCS use in <arch>/string/Makefile.inc.

Remove .c files which duplicate entries in MISRCS.
Use the same, less merge conflict prone style in all cases.
Use MDSRCS for mips (.c and .S files both ended up in SRCS).
Remove pointless sparc64 Makefile.inc.
Remove uninformative foreign VCS ID entries.

Correct an misunderstanding of MDSRCS.

MDSRCS it intended to allow assembly versions of funtions with C
implementations listed in MISRCS. The selection of the correct
machdep_ldis?.c for a given architecture does not follow this pattern
and the file should be added to SRCS directly.

Garbage collect unused gdtoa related files on mips.

Test Plan

Will perform a universe build before commit.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7817
Build 7961: arc lint + arc unit

Event Timeline

brooks updated this revision to Diff 25820.Feb 28 2017, 10:10 PM

brooks retitled this revision from to Tidy up machine dependent Makefiles in libc..

brooks updated this object.

brooks edited the test plan for this revision. (Show Details)

brooks added reviewers: jhb, adrian, imp.

Herald added a subscriber: emaste. · View Herald TranscriptFeb 28 2017, 10:10 PM

This LGTM

lgtm

This revision is now accepted and ready to land.Mar 1 2017, 2:40 PM

jhb accepted this revision.Mar 1 2017, 5:20 PM

jhb edited edge metadata.

Closed by commit rS314556: Correct MDSRCS use in <arch>/string/Makefile.inc. (authored by brooks). · Explain WhyMar 2 2017, 5:06 PM

This revision was automatically updated to reflect the committed changes.

fuz added a subscriber: fuz.Jul 7 2023, 5:41 PM

fuz added inline comments.

head/lib/libc/amd64/string/Makefile.inc
13 ↗	(On Diff #25903)	This change dropped our machdep `strcpy.c` implementation, so `strcpy` no longer calls into the assembly `stpcpy` to do its job. Will fix this in an upcoming DR.